Skip to content
Snippets Groups Projects

Use predicates instead of explicit checks of the status codes.

Merged Andrii Verbytskyi requested to merge averbyts/athena:predicats into 23.0

In this MR:

  • Use predicates instead of explicit checks of the status codes.
  • Move the isStatus1BSMParticle function to TruthUtils

Merge request reports

Pipeline #5832116 passed

Pipeline passed for f6f6792d on averbyts:predicats

Approval is optional

Merged by Chandler Robert BakerChandler Robert Baker 1 year ago (Jul 4, 2023 7:35pm UTC)

Merge details

  • Changes merged into 23.0 with 856e089e (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Sutton resolved all threads

    resolved all threads

  • :pencil: :scissors: CI integration tests for projects Athena,AthSimulation,AthGeneration are cancelled because of compilation error(s)

  • :x: CI Result FAILURE (hash f9e73ab0)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :o: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 6, warnings 3
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :o: AthGeneration: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73587]

  • Andrii Verbytskyi added 6 commits

    added 6 commits

    Compare with previous version

  • This merge request affects 13 packages:

    • ForwardDetectors/ALFA/ALFA_BeamTransport
    • Generators/EvtGen_i
    • Generators/TruthUtils
    • PhysicsAnalysis/AnalysisCommon/PMGOverlapRemovalTools/GammaORTools
    • PhysicsAnalysis/AnalysisCommon/ThinningUtils
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
    • PhysicsAnalysis/MCTruthClassifier
    • Reconstruction/Jet/BoostedJetTaggers
    • Reconstruction/Jet/JetMomentTools
    • Simulation/Tools/McEventCollectionFilter
    • Tracking/TrkTools/TrkTruthCreatorTools
    • Trigger/TrigAnalysis/TrigInDetAnalysisUtils
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

    Affected files list will not be printed in this case

    Adding @zmarshal ,@goetz ,@jchapman ,@cdelitzs ,@nagano ,@jveatch ,@keli ,@mleblanc ,@jcatmore ,@calpigia ,@meehan ,@serodrig ,@thompson ,@sutt ,@rnewhous ,@mvozak ,@sschramm as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 112K in file PhysicsAnalysis/MCTruthClassifier/Root/MCTruthClassifierGen.cxx

  • :pencil: :scissors: CI integration tests for projects Athena,AthSimulation are cancelled because of compilation error(s)

  • :x: CI Result FAILURE (hash 313b2d1d)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 3, warnings 0
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73598]

  • This merge request affects 13 packages:

    • ForwardDetectors/ALFA/ALFA_BeamTransport
    • Generators/EvtGen_i
    • Generators/TruthUtils
    • PhysicsAnalysis/AnalysisCommon/PMGOverlapRemovalTools/GammaORTools
    • PhysicsAnalysis/AnalysisCommon/ThinningUtils
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
    • PhysicsAnalysis/MCTruthClassifier
    • Reconstruction/Jet/BoostedJetTaggers
    • Reconstruction/Jet/JetMomentTools
    • Simulation/Tools/McEventCollectionFilter
    • Tracking/TrkTools/TrkTruthCreatorTools
    • Trigger/TrigAnalysis/TrigInDetAnalysisUtils
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

    Affected files list will not be printed in this case

    Adding @zmarshal ,@goetz ,@jchapman ,@cdelitzs ,@nagano ,@jveatch ,@keli ,@mleblanc ,@jcatmore ,@calpigia ,@meehan ,@serodrig ,@thompson ,@sutt ,@rnewhous ,@mvozak ,@sschramm as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 112K in file PhysicsAnalysis/MCTruthClassifier/Root/MCTruthClassifierGen.cxx

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading