Skip to content

TrigInDetValidation: propagate L1EM->L1eEM menu change

Bertrand Martin Dit Latour requested to merge martindl/athena:23.0_eEM_IDtests into 23.0

Hello,

As reported in ATR-27793, the TrigInDetValidation ART tests must be updated to propagate the removal of L1 EM legacy items (!63664 (merged)).

  • HLT_e20_idperf_loose_lrtloose_L1EM15VH -> HLT_e20_idperf_loose_lrtloose_L1eEM18L
  • HLT_e30_idperf_loose_lrtloose_L1EM22VHI -> HLT_e30_idperf_loose_lrtloose_L1eEM26M
  • HLT_e26_lhtight_ivarloose_e5_idperf_loose_lrtloose_probe_L1EM22VHI -> HLT_e26_lhtight_ivarloose_e5_idperf_loose_lrtloose_probe_L1eEM26M
  • HLT_e5_idperf_loose_lrtloose_probe_g25_medium_L1EM20VH -> HLT_e5_idperf_loose_lrtloose_probe_g25_medium_L1eEM24L
  • HLT_e26_idperf_loose_L1EM22VHI -> HLT_e26_idperf_loose_L1eEM26M
  • HLT_e26_lhtight_e14_idperf_tight_probe_50invmAB130_L1EM22VHI -> HLT_e26_lhtight_e14_idperf_tight_probe_50invmAB130_L1eEM26M
  • HLT_e26_lhtight_e14_idperf_tight_nogsf_probe_50invmAB130_L1EM22VHI -> HLT_e26_lhtight_e14_idperf_tight_nogsf_probe_50invmAB130_L1eEM26M
  • HLT_e26_lhtight_ivarloose_e30_lhloose_nopix_lrtmedium_probe_L1EM22VHI -> HLT_e26_lhtight_ivarloose_e30_lhloose_nopix_lrtmedium_probe_L1eEM26M
  • HLT_e30_lhloose_nopix_lrtmedium_probe_g25_medium_L1EM20VH -> HLT_e30_lhloose_nopix_lrtmedium_probe_g25_medium_L1eEM24L
  • HLT_e28_idperf_loose_L1EM22VHI -> HLT_e28_idperf_loose_L1eEM28M

I commented out the legacy chains, instead of removing them, for traceability. But if it is cleaner to remove them, let me know.

I also noticed a number of chains in comparitor.json that don't seem to have a eEM equivalent, maybe these are deprecated and don't exist anymore? If so, I would let experts drop the last few "L1EM" entries in a follow-up MR.

I didn't update TrigInDetAnalysisUser either (e.g. TIDAdata-chains-run3.dat).

Tagging @sutt , @keli , @adye , @hartj .

Cheers, Bertrand

Merge request reports