A step towards unification of HepMCHelpers definitions

A step towards unification of HepMCHelpers definitions.

the MR does not change the logic of the predicats inside HepMCHelpers. However, all of the predicates of interest are written in a more standard way.

@jchapman

This merge request affects 1 package:

• Generators/TruthUtils

This merge request affects 1 file:

• Generators/TruthUtils/TruthUtils/HepMCHelpers.h

Adding @zmarshal as watcher

added 23.0 Generators analysis-review-required review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash b2d0ed98)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73606]

marked this merge request as draft

CI clean, changes look OK from an L1 point of view. Approving - L1

removed review-pending-level-1 label

added review-approved label

Sorry, just saw its still a draft

removed review-approved label

added 97 commits

• b2d0ed98...464f8d96 - 96 commits from branch atlas:23.0
• f93b8a77 - Merge remote-tracking branch 'upstream/23.0' into simplify_hepmchelpers_1

Compare with previous version

Jenkins please retry the build.

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Generators/TruthUtils

This merge request affects 1 file:

• Generators/TruthUtils/TruthUtils/HepMCHelpers.h

Adding @zmarshal as watcher

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash f93b8a77)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73750]

Jenkins please retry the build

This merge request affects 1 package:

• Generators/TruthUtils

This merge request affects 1 file:

• Generators/TruthUtils/TruthUtils/HepMCHelpers.h

Adding @zmarshal as watcher

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

added Run3-MCOverlay-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash f93b8a77)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73813]

removed Run3-MCOverlay-output-changed label

removed Run3-MCReco-output-changed label

Jenkins please retry a build

This merge request affects 1 package:

• Generators/TruthUtils

This merge request affects 1 file:

• Generators/TruthUtils/TruthUtils/HepMCHelpers.h

Adding @zmarshal as watcher

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash f93b8a77)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73832]

added 89 commits

• f93b8a77...4606fd70 - 88 commits from branch atlas:23.0
• e8cbed16 - Merge remote-tracking branch 'upstream/23.0' into simplify_hepmchelpers_1

Compare with previous version

added 1 commit

• 49b557e4 - OK

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• Generators/TruthUtils

This merge request affects 1 file:

• Generators/TruthUtils/TruthUtils/HepMCHelpers.h

Adding @zmarshal as watcher

added review-pending-level-1 label

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 49b557e4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73918]

Two minor comments on code readability, else this looks good to me.

-- L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

removed review-user-action-required label

added review-pending-level-1 label

The changes look okay and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

added review-approved-point1 label

added analysis-review-approved label and removed analysis-review-required label

mentioned in commit d470dc79

merged

mentioned in merge request !64182 (merged)