MuonGeometry - Remove geometry version to convert stationPhi from AMDB -> Identifier scheme

• Remove the unneeded parsing of the Geometry version to obtain a phi index out of the amdb phi index
• Add back conversion function to go from phi to amdb

This merge request affects 3 packages:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added 23.0 MuonSpectrometer review-pending-level-1 labels

CI Result SUCCESS (hash b8203b5b)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73640]

removed review-pending-level-1 label

added 1 commit

• d92bda55 - Add back conversion function

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added review-pending-level-1 label

changed the description

CI Result SUCCESS (hash d92bda55)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73685]

resolved all threads

added 1 commit

• c92a1917 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

CI Result SUCCESS (hash c92a1917)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73711]

MR looks good from my side except for one suspected indirect include.

Also pinging @akraszna for the unittest inclusion in CMakeLists.

-- L1 shifter

added review-user-action-required label

removed review-pending-level-1 label

resolved all threads

added review-pending-level-1 label

removed review-user-action-required label

MR looks good, passing on to expert review for CMakeLists changes.

-- L1 shifter

added review-pending-expert label and removed review-pending-level-1 label

I doubt that the expert review is neccessary here

removed review-pending-expert label

added review-pending-level-1 label

added review-pending-level-2 label

removed review-pending-level-1 label

Looks good. Karolos (L2)

added review-approved label and removed review-pending-level-2 label

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit 13d200bf

merged

mentioned in merge request !64153 (merged)

Causes probably ATLASSIM-6639