RoiDescriptor: cleanup code to set default z-width

Instead of the complicated function pointer logic, simply set a flag when the first RoiDescriptor has been created and throw an exception in case the z-width is being changed afterwards.

added full-integration-tests full-unit-tests labels

This merge request affects 2 packages:

• DetectorDescription/RoiDescriptor
• Trigger/TrigSteer/HLTSeeding

Affected files list will not be printed in this case

Adding @apsallid ,@sutt ,@fpastore ,@stavrop ,@tamartin ,@keli ,@rbianchi ,@jojungge as watchers

added 23.0 Geometry Trigger analysis-review-required review-pending-level-1 labels

Hi Frank, not really against these changes, as this code was a bit of a mess and needed to be fixed properly anyhow, but this does change the behaviour, as the functionality that was there, sets the flag the first time and then replaces all subsequent calls with an empty function such that no subsequent calls actually do anything. However, in the new code, there will always be the check, and if the function is called more than once therewill be an exception. Given the multi threaded natiore of the code, I wasn't sure whether there would guaranteed only ever be one instance of the HLTSeeding, or whether there might conceievably ever be separate instances created eg in the different threads which was why it was implemented this way. I guess as it should only be called during the imitialize() any how the speed improvement by not having to check the flags for subsequent calls is marginal and likely not so importtant overall, so if we wanted to keep this behaviour I guess we would remove the exception ? If the seeding were a singleton class then I guess we could leave it in.

resolved all threads

CI Result SUCCESS (hash 7e976d6a)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73644]

The changes look okay and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added analysis-review-approved label and removed analysis-review-required label

added review-approved-tier0 label

mentioned in commit 464f8d96

merged

mentioned in merge request !64101 (merged)