Fixing crash in run 4 offline FTF ART tests

As title describes, this fixes a crash occuring for two run 4 ART tests for running FTF as an offline algorithm with an ITk dataset. This crash was introduced via !63842 (merged) where the values of "flags.Tracking.ActiveConfig.doHitDV" and "flags.Tracking.ActiveConfig.doDisappearingTrk" are required. However, previously for these ART tests, trigger-specific flags were not needing to be set up and hence doHitDV and doDisappearingTrk were never created - causing the crash when they are now required.

This change simply adds in the required flags to the FTF pass of the ITk flags.

Fixes issue related to ATLSWUPGR-201

This MR targets master as the ART tests only run in master, and this is all purely upgrade-related code.

Tagging @smh @tstreble

changed the description

Hi @ewatton, thanks for looking into this. @jmasik does this look reasonable to you?

added 1 commit

• 6ec5afaf - Changing fix to including missing flags in the FTF ITk pass flags

Compare with previous version

resolved all threads

marked this merge request as ready

changed the description

This merge request affects 1 package:

• Tracking/TrkConfig

This merge request affects 1 file:

• Tracking/TrkConfig/python/TrackingPassFlags.py

added Tracking master review-pending-level-1 labels

added ITk InnerDetector labels

added Run3-MCOverlay-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 6ec5afaf)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73803]

marked this merge request as draft

Hi, does anyone know a reason why my changes could inmpact Run 3 output if they only alter the set of flags used only for a specific ITk job?

There are is some general problem - these CI failures affect multiple MRs.

removed Run3-MCOverlay-output-changed label

removed Run3-MCReco-output-changed label

Jenkins please retry a build

@ewatton the issue with the Run 3 outputs should have been fixed now. Can this be undrafted or was there anything else you wanted to update?

This merge request affects 1 package:

• Tracking/TrkConfig

This merge request affects 1 file:

• Tracking/TrkConfig/python/TrackingPassFlags.py

removed review-pending-level-1 label

CI Result SUCCESS (hash 6ec5afaf)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73839]

resolved all threads

marked this merge request as ready

This merge request affects 1 package:

• Tracking/TrkConfig

This merge request affects 1 file:

• Tracking/TrkConfig/python/TrackingPassFlags.py

added review-pending-level-1 label

CI Result SUCCESS (hash 6ec5afaf)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73860]

CI clean, changes look good from an L1 point of view. Approving - L1

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit a89d80cd

added sweep:ignore label