23.0-coverity-InDetEventCnv

(Hopefully) resolving all coverity defects in InDetEventCnv. Started by addressing 18076-18078 (no need to check pointer, when this is done in the function and returned as a bool), introduced in January 2023. Continued to check dynamic casts where necessary. Some tidying of headers also done.

This merge request affects 4 packages:

• InnerDetector/InDetEventCnv/BCM_RawDataByteStreamCnv
• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv

Affected files list will not be printed in this case

Adding @goetz ,@cgrefe ,@ibragimo ,@battagl ,@sroe ,@calfayan ,@gemmeren ,@stsuno ,@lshan as watchers

added 23.0 InnerDetector review-pending-level-1 labels

CI Result FAILURE (hash c0ea2796)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73826]

Jenkins please retry a build

This merge request affects 4 packages:

• InnerDetector/InDetEventCnv/BCM_RawDataByteStreamCnv
• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv

Affected files list will not be printed in this case

Adding @goetz ,@cgrefe ,@ibragimo ,@battagl ,@sroe ,@calfayan ,@gemmeren ,@stsuno ,@lshan as watchers

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result FAILURE (hash c0ea2796)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73847]

Jenkins please retry a build

This merge request affects 4 packages:

• InnerDetector/InDetEventCnv/BCM_RawDataByteStreamCnv
• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv

Affected files list will not be printed in this case

Adding @goetz ,@cgrefe ,@ibragimo ,@battagl ,@sroe ,@calfayan ,@gemmeren ,@stsuno ,@lshan as watchers

CI here is failing at test CITest_ACTS_ValidateClusterstest. From the stack-trace, this might be related to the changes implemented by this MR. Can you take a look @sroe?

-- L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

removed review-user-action-required label

added review-pending-level-1 label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result FAILURE (hash c0ea2796)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73863]

marked this merge request as draft

Hi @tadej , I checked out CITest and ran the offending test locally with no failure. Let me try in the 'official' CI once again.

marked this merge request as ready

Jenkins please retry a build

This merge request affects 4 packages:

• InnerDetector/InDetEventCnv/BCM_RawDataByteStreamCnv
• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv

Affected files list will not be printed in this case

Adding @goetz ,@cgrefe ,@ibragimo ,@battagl ,@sroe ,@calfayan ,@gemmeren ,@stsuno ,@lshan as watchers