Skip to content
Snippets Groups Projects

fix message level in LArCellConditions.py

Merged Walter Lampl requested to merge wlampl/athena:LArCellCondMsgFix into 23.0

the title says it all..

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Changes look good except one suggestion on using a defined constant for the logging level instead of the magic constant.

    -- L1 shifter

  • Walter Lampl added 1 commit

    added 1 commit

    • 9538a980 - LArCellConditions.py: Use Constants + initConfigFlags

    Compare with previous version

  • This merge request affects 1 package:

    • LArCalorimeter/LArExample/LArConditionsCommon

    This merge request affects 1 file:

    • LArCalorimeter/LArExample/LArConditionsCommon/share/LArCellConditions.py

    Adding @pavol as watcher

  • :white_check_mark: CI Result SUCCESS (hash 9538a980)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74020]

  • Chris Scheulen resolved all threads

    resolved all threads

  • Change here looks good from my perspective, approving.

    -- L1 shifter

  • added review-approved label and removed review-pending-level-1 label

  • Julien Maurer mentioned in commit 6213f08b

    mentioned in commit 6213f08b

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading