23.0-coverity-MuonTesterTre

solve coverity defects introduced recently(May-July 2023): include header recursion, unchecked return value

This merge request affects 1 package:

• MuonSpectrometer/MuonValidation/MuonTesterTree

This merge request affects 4 files:

• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/EventInfoBranch.h
• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/ScalarBranch.icc
• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/SetBranch.icc
• MuonSpectrometer/MuonValidation/MuonTesterTree/Root/EventInfoBranch.cxx

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added 23.0 MuonSpectrometer review-pending-level-1 labels

CI Result SUCCESS (hash 8bbb84d2)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74015]

A question on the removal of the includes and a very minor comment on code style.

-- L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• e61da827 - wspace change

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonValidation/MuonTesterTree

This merge request affects 4 files:

• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/EventInfoBranch.h
• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/ScalarBranch.icc
• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/SetBranch.icc
• MuonSpectrometer/MuonValidation/MuonTesterTree/Root/EventInfoBranch.cxx

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash e61da827)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74025]

Looking good from my side now that everything is resolved, approved.

-- L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 24e2002a - Update EventInfoBranch.cxx per shifter advice.

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonValidation/MuonTesterTree

This merge request affects 4 files:

• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/EventInfoBranch.h
• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/ScalarBranch.icc
• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/SetBranch.icc
• MuonSpectrometer/MuonValidation/MuonTesterTree/Root/EventInfoBranch.cxx

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 24e2002a)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74039]

resolved all threads

added review-approved label

removed review-pending-level-1 label

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit 32b3bd6f

merged

mentioned in merge request !64217 (merged)