Suppress TBB Warnings with C++20, 23.0 branch (2023.07.06.)

Another "strategy" could be to simply wait for the upgrade of the dev4 nightlies to oneAPI TBB, which may fix those warnings at the source. But that will probably take a few more weeks. So I would vote for going ahead with this at least as a short-term fix. That will allow us to get an idea how many real compiler warnings we have in our gcc13 nightlies.

Let me re-point it to 23.0 then, just so that we would do it properly...

added 33 commits

0646e364...1a4fb761 - 23 earlier commits
97ed44ad - Make ATLFAST3F_G4MS configuration match ATLFAST3 configuration except that ISF...
ccc154b7 - Merge branch 'ATLFAST3F_G4MS_23.0' into '23.0'
5bd27595 - Include !63964 (merged) in 23.0
9df62f66 - Merge branch 'svanstro-23.0-patch-42251' into '23.0'
66fbc398 - MuonGeoModelTest - Add CSC tester
cee54637 - Merge branch 'CscILines' into '23.0'
19978723 - Merge branch '23.0_improve_error_messages_of_expression_parser' into '23.0'
fbdf5495 - Demo script to produce a bad channel list
a8a7eaa8 - Merge branch 'LArCusterCellMonReader' into '23.0'
38e8e8bc - Suppress warnings about volatile variables for Cling.

Compare with previous version

changed target branch from main to 23.0

marked this merge request as ready

This merge request affects 1 package:

Control/AthContainers

This merge request affects 1 file:

Control/AthContainers/AthContainers/tools/threading.h

Adding @ssnyder as watcher

added 23.0 Core analysis-review-required review-pending-level-1 labels

changed title from Suppress TBB Warnings with C++20, main branch (2023.07.06.) to Suppress TBB Warnings with C++20, 23.0 branch (2023.07.06.)

CI Result SUCCESS (hash 38e8e8bc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74028]

removed review-pending-level-1 label

added review-approved label

added review-approved-tier0 label

added analysis-review-approved label and removed analysis-review-required label

added review-approved-point1 label

mentioned in commit fad4671a

merged

mentioned in merge request !64217 (merged)

Hey

@akraszna

there are many warnings

[https://bigpanda.cern.ch/compsview/?nightly=main--dev4LCG_Athena_x86_64-el9-gcc13-opt&rel=2023-07-09T0730&ar=x86_64-el9-gcc13-opt&proj=Athena]

                 from /build/atnight/localbuilds/nightlies/main--dev4LCG/athena/Tracking/Acts/ActsDataPreparation/src/ActsCoreStripSpacePointFormationTool.cxx:5:
/build/atnight/localbuilds/nightlies/main--dev4LCG/athena/Control/AthContainers/AthContainers/tools/threading.h:137: warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
  137 | #pragma clang diagnostic push
      | 
/build/atnight/localbuilds/nightlies/main--dev4LCG/athena/Control/AthContainers/AthContainers/tools/threading.h:138: warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
  138 | #pragma clang diagnostic ignored "-Wdeprecated-volatile"
      | 
/build/atnight/localbuilds/nightlies/main--dev4LCG/athena/Control/AthContainers/AthContainers/tools/threading.h:142: warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
  142 | #pragma clang diagnostic pop

Do now know if

defined(__clang__)

is needed i.e

#if defined(__clang__)
#if __cplusplus > 201703L
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-volatile"
#endif  // >C++17
#include "tbb/concurrent_vector.h"
#if __cplusplus > 201703L
#pragma clang diagnostic pop
#endif  // >C++17
#endif //clang

I don't know how I missed these. See !64240 (merged) for my fix attempt.

mentioned in merge request !64240 (merged)

Adding -Wno-deprecated-volatile to the genreflex command line seems to work for me. I think that would be much preferable to putting suppressions in our code. (And should we actually have this situation in our code, it should be flagged by the regular clang compilation.)

But how many dictionary generation commands would we need to add that flag to?

Clang compilation will not show this issue. Since clang respects -isystem just fine. Without an issue in genreflex with it not respecting -isystem, we would not have had to do any of this.

All in all, I still think that this addition (together with !64240 (merged)) was the most pragmatic thing to do...

One --- in the atlas_generate_reflex_dictionary cmake function. (Ok, maybe also in atlas_add_root_dictionary.)

And i wasn't referring to the instance of this in the TBB headers, but rather some hypothetical instance of it in the Athena code. The point was that disabling this warning globally for all genreflex runs won't blind us to instances of this in our code since they should still be diagnosed by the clang builds. (Though i don't think we have anything that would actually trip this warning.)

Suppress TBB Warnings with C++20, 23.0 branch (2023.07.06.)

Merge request reports

Activity