fix for inductive xtalk in EM2 cells impacting timing use in CaloTopoCluster

manual sweep from MR !64222 (closed) for rel23

This merge request affects 1 package:

• Calorimeter/CaloRec

This merge request affects 6 files:

• Calorimeter/CaloRec/python/CaloClusterTopoGetter.py
• Calorimeter/CaloRec/python/CaloConfigFlags.py
• Calorimeter/CaloRec/python/CaloTopoClusterConfig.py
• Calorimeter/CaloRec/python/CaloTopoClusterFlags.py
• Calorimeter/CaloRec/src/CaloTopoClusterMaker.cxx
• Calorimeter/CaloRec/src/CaloTopoClusterMaker.h

Adding @pavol as watcher

added 23.0 Calorimeter review-pending-level-1 labels

CI Result SUCCESS (hash d8fdcf0a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74195]

mentioned in merge request !64222 (closed)

Changing label to review-user-action-required until the discussion is resolved. Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 9d5f19b8 - clean up of the xtalk in EM2 fix for TopoCluster

Compare with previous version

This merge request affects 1 package:

• Calorimeter/CaloRec

This merge request affects 6 files:

• Calorimeter/CaloRec/python/CaloClusterTopoGetter.py
• Calorimeter/CaloRec/python/CaloConfigFlags.py
• Calorimeter/CaloRec/python/CaloTopoClusterConfig.py
• Calorimeter/CaloRec/python/CaloTopoClusterFlags.py
• Calorimeter/CaloRec/src/CaloTopoClusterMaker.cxx
• Calorimeter/CaloRec/src/CaloTopoClusterMaker.h

Adding @pavol as watcher

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result FAILURE (hash 9d5f19b8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74265]

Hey @wlampl @fwinkl

 noerror.sh> ERROR: Found the following errors in Trigger_athenaHLT_v1Cosmic.log:

does not seem related. Will give a retry but seems to randomly happen ....

Jenkins please retry a build

This merge request affects 1 package:

• Calorimeter/CaloRec

This merge request affects 6 files:

• Calorimeter/CaloRec/python/CaloClusterTopoGetter.py
• Calorimeter/CaloRec/python/CaloConfigFlags.py
• Calorimeter/CaloRec/python/CaloTopoClusterConfig.py
• Calorimeter/CaloRec/python/CaloTopoClusterFlags.py
• Calorimeter/CaloRec/src/CaloTopoClusterMaker.cxx
• Calorimeter/CaloRec/src/CaloTopoClusterMaker.h

Adding @pavol as watcher

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash 9d5f19b8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74313]

mentioned in merge request !64076 (merged)

mentioned in merge request !64255 (merged)

Changes look fine to me and the CI is good. All threads have been resolved. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

Even though nothing changed for the few events we process in the CI, shouldn't this MR be considered frozen-tier0-violating ? It is meant to change the output for at least some events, right?

if we turn it on will be . With off is the same as before ....

so the frozen-tier0-violating will happen for reprocessing , assuming the discussion in PC ping @ludovica @gunal concludes. [https://indico.cern.ch/event/1305571/contributions/5490322/attachments/2681410/4651846/egamma-timing-cut-10jul2023.pdf]

Quoting from the summary of the discussion that got propagated :

a) The so called "longer term” fix ( Eg. Sven MR 64237 ) need to be validated (both energy fraction and Dtime) —> most probably This fix will go in in new rel 24 and data22+data23 will be reprocessed during Christmas reprocessing

b) In the mean time we need to work on the "short term” plan : a fix a derivation level for data23 and data22( reprocess with rel 23 ) Guillaume suggested to add decoration of E1 E2 and Eclu with the recovered cells using the 7x11 cells information that we store in the AOD

This if for a the longer term proper one ...

But is off by default so nothing should be changing for FT0. Turning it on will be FT0 violating. If we assume this (FT0) applies to rel 24 or whatever the number will be .

Christos was faster ... and he's right. The code added is not called since the flag to activate it is false by default. So you have to actively turn it on with Calo.TopoCluster.xtalkEM2=True if you want to see any change.

added review-approved-point1 label

mentioned in commit e675e71c

merged

mentioned in merge request !64323 (merged)

resolved all threads