GCC Clang Pragma Warning Fix, 23.0 branch (2023.07.10.)

As it turns out (see !64172 (comment 6900052) and https://bigpanda.cern.ch/nview/?nightly=main--dev4LCG_Athena_x86_64-el9-gcc13-opt), GCC is very touchy about seeing pragmas that are not meant for it. So we need to only expose these pragmas to the ROOT dictionary generation. Even Clang as the main C++ compiler does not need to see them.

This is a follow-up to !64172 (merged). But I still don't know how I missed these while writing that MR.

Let's hope that this will be the end of this issue (ATLINFR-4996)... Pinging @christos and @elmsheus.

added bugfix label

mentioned in merge request !64172 (merged)

This merge request affects 1 package:

• Control/AthContainers

This merge request affects 1 file:

• Control/AthContainers/AthContainers/tools/threading.h

Adding @ssnyder as watcher

added 23.0 Core analysis-review-required review-pending-level-1 labels

changed the description

CI Result SUCCESS (hash b9e70ef7)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74200]

removed review-pending-level-1 label

added review-approved label

added analysis-review-approved label and removed analysis-review-required label

mentioned in commit cfb0609c

merged

mentioned in merge request !64286 (closed)

mentioned in merge request !64323 (merged)