Use C++17 std::filesystem instead of boost::filesystem where possible
Use C++17 std::filesystem instead of boost::filesystem where possible
Merge request reports
Activity
This merge request affects 8 packages:
- Calorimeter/CaloRecGPU
- Control/AthenaKernel
- Control/AthenaMP
- Control/AthenaMPTools
- Control/PerformanceMonitoring/PerfMonComps
- HLT/Trigger/TrigControl/TrigServices
- PhysicsAnalysis/D3PDTools/EventLoop
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
Affected files list will not be printed in this case
Adding @gemmeren ,@fpastore ,@maszyman ,@fwinkl ,@krumnack ,@pavol ,@amete ,@wiedenma ,@ssnyder as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Resolved by Nils Erik KrumnackNo. Let's not do this.
std::filesystemis super fiddly with the current compilers that we use. Note that you didn't even update any of the CMake configuration files, so it's a bit of a mystery how everything managed to link successfully.
https://gitlab.kitware.com/cmake/cmake/-/issues/17834
For instance in Gaudi we ended up with an (in my mind) way too complicated logic for being able to use
std::filesystemin the circumstances where it is available.https://gitlab.cern.ch/gaudi/Gaudi/-/blob/master/GaudiPluginService/CMakeLists.txt#L20-38
Instead of just always using
boost::filesystemeverywhere...So no, let's not do this in Athena.
boost::filesystemis still way more portable thanstd::filesystemis.- Last reply by Nils Erik Krumnack
removed review-pending-level-1 label
-
This merge request affects 8 packages:
- Calorimeter/CaloRecGPU
- Control/AthenaKernel
- Control/AthenaMP
- Control/AthenaMPTools
- Control/PerformanceMonitoring/PerfMonComps
- HLT/Trigger/TrigControl/TrigServices
- PhysicsAnalysis/D3PDTools/EventLoop
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
Affected files list will not be printed in this case
Adding @fpastore ,@krumnack ,@pavol ,@amete ,@wiedenma ,@gemmeren ,@maszyman ,@fwinkl ,@ssnyder as watchers
added review-pending-level-1 label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests 
Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Resolved by Andrii VerbytskyiLet me ping
This is the 3rd time (I have seen) this test fails today on an unrelated MR
see [!64237 (merged)]
it succeeded after re-try. Do we have a JIRA already ?
mentioned in merge request !64076 (merged)
added 19 commits
-
edc61ce7...0b2f8b74 - 18 commits from branch
atlas:23.0 - 1146116f - Merge remote-tracking branch 'upstream/23.0' into filesystem
-
edc61ce7...0b2f8b74 - 18 commits from branch
-
This merge request affects 8 packages:
- Calorimeter/CaloRecGPU
- Control/AthenaKernel
- Control/AthenaMP
- Control/AthenaMPTools
- Control/PerformanceMonitoring/PerfMonComps
- HLT/Trigger/TrigControl/TrigServices
- PhysicsAnalysis/D3PDTools/EventLoop
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
Affected files list will not be printed in this case
Adding @fpastore ,@krumnack ,@pavol ,@amete ,@wiedenma ,@gemmeren ,@maszyman ,@fwinkl ,@ssnyder as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 22 commits
-
1146116f...abb016e2 - 21 commits from branch
atlas:23.0 - b0654065 - Merge remote-tracking branch 'upstream/23.0' into filesystem
-
1146116f...abb016e2 - 21 commits from branch