Skip to content
Snippets Groups Projects

TrigT1NSWSimTools: minor code cleanup

Merged TrigT1NSWSimTools: minor code cleanup
martindl/athena:23.0_test into 23.0
All threads resolved!
Merged Bertrand Martin Dit Latour requested to merge martindl/athena:23.0_test into 23.0
All threads resolved!

Hello,

This MR is doing minor code cleanup, e.g. passing by value/reference. Tagging @fgravili .

Cheers, Bertrand

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Stewart Martin-HaughStewart Martin-Haugh 1 year ago (Jul 13, 2023 2:10pm UTC)

Merge details

  • Changes merged into 23.0 with 44ea90dd (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigT1/TrigT1NSWSimTools

    This merge request affects 21 files:

    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/L1TdrStgcTriggerLogic.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Diamond.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Road.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTdsOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTriggerLogicOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/SingleWedgePadTrigger.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/StripSegmentTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/src/GeoUtils.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/L1TdrStgcTriggerLogic.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMFPGAOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMStripTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Diamond.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Fitter.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Road.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_struct.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLogicOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLookupTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/SingleWedgePadTrigger.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/StripSegmentTool.cxx

    Adding @serodrig as watcher

  • ATLAS Robot added 23.0 Trigger review-pending-level-1 labels

    added 23.0 Trigger review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 52c9b530)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74235]

  • Joana Niermann removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Joana Niermann added review-user-action-required label

    added review-user-action-required label

  • Bertrand Martin Dit Latour added 1 commit

    added 1 commit

    Compare with previous version

  • Bertrand Martin Dit Latour resolved all threads

    resolved all threads

  • Bertrand Martin Dit Latour removed review-user-action-required label

    removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigT1/TrigT1NSWSimTools

    This merge request affects 21 files:

    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/L1TdrStgcTriggerLogic.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Diamond.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Road.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTdsOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTriggerLogicOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/SingleWedgePadTrigger.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/StripSegmentTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/src/GeoUtils.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/L1TdrStgcTriggerLogic.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMFPGAOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMStripTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Diamond.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Fitter.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Road.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_struct.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLogicOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLookupTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/SingleWedgePadTrigger.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/StripSegmentTool.cxx

    Adding @serodrig as watcher

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • Bertrand Martin Dit Latour added review-pending-expert label and removed review-pending-level-1 label

    added review-pending-expert label and removed review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • Bertrand Martin Dit Latour added review-pending-level-1 label

    added review-pending-level-1 label

  • Bertrand Martin Dit Latour removed review-pending-expert label

    removed review-pending-expert label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1097c238)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74266]

  • Francesco Giuseppe Gravili
    Francesco Giuseppe Gravili @fgravili ·
    Developer

    Hi @martindl, thanks a lot! Just for completeness, I didn't push these changes before because I received this comment some time ago (it took me a while to dig it up)

  • Bertrand Martin Dit Latour added 1 commit

    added 1 commit

    • 9377190c - delete unused code rather than commenting it out

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigT1/TrigT1NSWSimTools

    This merge request affects 21 files:

    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/L1TdrStgcTriggerLogic.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Diamond.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Road.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTdsOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTriggerLogicOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/SingleWedgePadTrigger.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/StripSegmentTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/src/GeoUtils.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/L1TdrStgcTriggerLogic.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMFPGAOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMStripTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Diamond.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Fitter.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Road.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_struct.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLogicOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLookupTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/SingleWedgePadTrigger.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/StripSegmentTool.cxx

    Adding @serodrig as watcher

  • Bertrand Martin Dit Latour resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 9377190c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74337]

  • Bertrand Martin Dit Latour
    Bertrand Martin Dit Latour @martindl ·
    Author Developer

    CI failure due to ATR-27922, unrelated to this MR.

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigT1/TrigT1NSWSimTools

    This merge request affects 21 files:

    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/L1TdrStgcTriggerLogic.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Diamond.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Road.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTdsOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/PadTriggerLogicOfflineTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/SingleWedgePadTrigger.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/StripSegmentTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/src/GeoUtils.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/L1TdrStgcTriggerLogic.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMFPGAOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMStripTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Diamond.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Fitter.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Road.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_struct.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTdsOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLogicOfflineTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/PadTriggerLookupTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/SingleWedgePadTrigger.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/StripSegmentTool.cxx

    Adding @serodrig as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 9377190c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74392]

  • Bertrand Martin Dit Latour resolved all threads

    resolved all threads

  • Carlo Varni
    Carlo Varni @cvarni ·
    Developer

    lgtm

  • Carlo Varni added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Stewart Martin-Haugh mentioned in commit 44ea90dd

    mentioned in commit 44ea90dd

  • Stewart Martin-Haugh merged

    merged

  • Vakhtang Tsulaia mentioned in merge request !64356 (merged)

    mentioned in merge request !64356 (merged)

    • Please register or sign in to reply