Skip to content
Snippets Groups Projects

MuonGeoModelTest - Add algorithm to dump the local pad positions (sTgc)

Merged MuonGeoModelTest - Add algorithm to dump the local pad positions (sTgc)
jojungge/athena:PadDrawing into 23.0
All threads resolved!
Merged Johannes Junggeburth requested to merge jojungge/athena:PadDrawing into 23.0
All threads resolved!

This MR adds a simple algorithm to dump the stgc pad positions into a TGraph. Essential for later validation purposes of the Run 3 & 4 geometry.

Tagging @ivyas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • J
    Joana Niermann @jonierma ·
    Developer

    L1

  • Joana Niermann removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Joana Niermann added review-user-action-required label

    added review-user-action-required label

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 78018868 - Apply 5 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonGeoModelTest

    This merge request affects 6 files:

    • MuonSpectrometer/MuonGeoModelTest/python/MuonGeoSetup.py
    • MuonSpectrometer/MuonGeoModelTest/python/PlotNSWGeo.py
    • MuonSpectrometer/MuonGeoModelTest/src/NSWGeoPlottingAlg.cxx
    • MuonSpectrometer/MuonGeoModelTest/src/components/MuonGeoModelTest_entries.cxx
    • MuonSpectrometer/MuonGeoModelTest/src/sTgcPadPlottingAlg.cxx
    • MuonSpectrometer/MuonGeoModelTest/src/sTgcPadPlottingAlg.h

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 78018868)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74363]

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • James Beacham
    James Beacham @jbeacham ·
    Developer

    The changes look okay and there are no issues with the CI. Approving from L1.

  • James Beacham added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Walter Lampl added review-approved-tier0 label

    added review-approved-tier0 label

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Author Developer

    @smh happy with the MR?

  • Walter Lampl
    Walter Lampl @wlampl ·
    Owner

    This MR also deletes a file (MuonGeoSetup.py). Intentional? This is not mentioned in the description.

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Author Developer

    Yeah, the file is pretty useless

  • Walter Lampl mentioned in commit da2bb8b0

    mentioned in commit da2bb8b0

  • Walter Lampl merged

    merged

  • Vakhtang Tsulaia mentioned in merge request !64388 (merged)

    mentioned in merge request !64388 (merged)

    • Please register or sign in to reply