23.0-bugfix-PixelConditionsData

Addresses ATLASSIM-6660 and the comments made in !64185 (merged). In the (rare) case that charge calibration resulted in a large charge result from the legacy fit (in excess of 1e5), and a linear fit was resorted to but failed due to the divisor in the calculation being zero, the existing logic in rel.23 returned the legacy fit result anyway. In my refactoring, I had inadvertently changed that to return the 'invalid' value of 0.0. Logic is here introduced which reverts to the previous behaviour.

added bugfix urgent labels

This merge request affects 1 package:

• InnerDetector/InDetConditions/PixelConditionsData

This merge request affects 1 file:

• InnerDetector/InDetConditions/PixelConditionsData/src/PixelChargeCalibCondData.cxx

Adding @goetz ,@lshan ,@battagl ,@sroe ,@stsuno as watchers

added 23.0 InnerDetector review-pending-level-1 labels

tagging @jmaurer and @christos as reco coordinators. This was discussed in https://indico.cern.ch/event/1306300/contributions/5493591/attachments/2682280/4653154/PROC-SC-2023-07-11.pdf

mentioned in merge request !64185 (merged)

resolved all threads

CI Result SUCCESS (hash ead92aa3)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74378]

resolved all threads

CI clean, changes OK from an L1 point of view. Approving since its urgent - L1

removed review-pending-level-1 label

added review-approved label

mentioned in commit 37c31786

merged

mentioned in merge request !64323 (merged)

added frozen-tier0-violating label