Skip to content
Snippets Groups Projects

Naming convention for Acts config JOs

Merged Naming convention for Acts config JOs
cvarni/athena:NamingConventionConfig into main
All threads resolved!
Merged Carlo Varni requested to merge cvarni/athena:NamingConventionConfig into main
All threads resolved!

Consistently with the rest of the ACTS suite, this drops the Trk in the JO config files and methods.

/cc @adye @ncalace @goetz

Merge request reports

Pipeline #5941010 passed

Stage: external

    Pipeline passed for f628c1c7 on cvarni:NamingConventionConfig

    Approval is optional

    Merged by Frank WinklmeierFrank Winklmeier 1 year ago (Jul 24, 2023 12:49pm UTC)

    Merge details

    • Changes merged into main with 867f502e (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • A
    Alexander Undrus @aundrus ·
    Maintainer

    CI job is restarted after the GitLab intervention

  • A
    Alexander Undrus @aundrus ·
    Maintainer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 12 packages:

    • AtlasTest/CITest
    • InnerDetector/InDetConfig
    • InnerDetector/InDetValidation/InDetPhysValMonitoring
    • PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
    • Simulation/ISF/ISF_Acts/ISF_ActsTools
    • Tracking/Acts/ActsConfig
    • Tracking/Acts/ActsEventCnv
    • Tracking/Acts/ActsGeantFollowing
    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsMonitoring
    • Tracking/Acts/ActsTrackReconstruction
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@jchapman ,@lgagnon ,@gavrilen ,@sroe ,@jsandesa ,@pagessin ,@jojungge ,@toyamaza ,@tcuhadar ,@fwinkl ,@tbold ,@cvarni ,@keli as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 0d6617c6)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74424]

  • Carlo Varni added 1 commit

    added 1 commit

    • b22c9057 - Add track in fitting and finding

    Compare with previous version

  • Carlo Varni resolved all threads

    resolved all threads

  • Carlo Varni
    Carlo Varni @cvarni ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 12 packages:

    • AtlasTest/CITest
    • InnerDetector/InDetConfig
    • InnerDetector/InDetValidation/InDetPhysValMonitoring
    • PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
    • Simulation/ISF/ISF_Acts/ISF_ActsTools
    • Tracking/Acts/ActsConfig
    • Tracking/Acts/ActsEventCnv
    • Tracking/Acts/ActsGeantFollowing
    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsMonitoring
    • Tracking/Acts/ActsTrackReconstruction
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@jchapman ,@lgagnon ,@gavrilen ,@sroe ,@jsandesa ,@pagessin ,@jojungge ,@toyamaza ,@tcuhadar ,@fwinkl ,@tbold ,@cvarni ,@keli as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash b22c9057)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74457]

  • Carlo Varni added 1 commit

    added 1 commit

    Compare with previous version

  • Carlo Varni
    Carlo Varni @cvarni ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 12 packages:

    • AtlasTest/CITest
    • InnerDetector/InDetConfig
    • InnerDetector/InDetValidation/InDetPhysValMonitoring
    • PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
    • Simulation/ISF/ISF_Acts/ISF_ActsTools
    • Tracking/Acts/ActsConfig
    • Tracking/Acts/ActsEventCnv
    • Tracking/Acts/ActsGeantFollowing
    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsMonitoring
    • Tracking/Acts/ActsTrackReconstruction
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@jchapman ,@lgagnon ,@gavrilen ,@sroe ,@jsandesa ,@pagessin ,@jojungge ,@toyamaza ,@tcuhadar ,@fwinkl ,@tbold ,@cvarni ,@keli as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash fc1d6c70)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74510]

  • Carlo Varni added 435 commits

    added 435 commits

    Compare with previous version

  • Carlo Varni added 1 commit

    added 1 commit

    Compare with previous version

  • Carlo Varni marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 13 packages:

    • AtlasTest/CITest
    • InnerDetector/InDetConfig
    • InnerDetector/InDetValidation/InDetPhysValMonitoring
    • PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
    • Simulation/ISF/ISF_Acts/ISF_ActsTools
    • Tracking/Acts/ActsConfig
    • Tracking/Acts/ActsDataPreparation
    • Tracking/Acts/ActsEventCnv
    • Tracking/Acts/ActsGeantFollowing
    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsMonitoring
    • Tracking/Acts/ActsTrackReconstruction
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@jchapman ,@lgagnon ,@stsuno ,@gavrilen ,@sroe ,@keli ,@pagessin ,@jojungge ,@toyamaza ,@tcuhadar ,@fwinkl ,@tbold ,@lshan ,@cvarni ,@battagl as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 6d810153)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75040]

  • Carlo Varni added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 13 packages:

    • AtlasTest/CITest
    • InnerDetector/InDetConfig
    • InnerDetector/InDetValidation/InDetPhysValMonitoring
    • PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
    • Simulation/ISF/ISF_Acts/ISF_ActsTools
    • Tracking/Acts/ActsConfig
    • Tracking/Acts/ActsDataPreparation
    • Tracking/Acts/ActsEventCnv
    • Tracking/Acts/ActsGeantFollowing
    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsMonitoring
    • Tracking/Acts/ActsTrackReconstruction
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@jchapman ,@lgagnon ,@stsuno ,@gavrilen ,@sroe ,@keli ,@pagessin ,@jojungge ,@toyamaza ,@tcuhadar ,@fwinkl ,@tbold ,@lshan ,@cvarni ,@battagl as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash f628c1c7)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75050]

  • J
    Joana Niermann @jonierma ·
    Developer

    Latest CI clean, changes look OK from an L1 point of view. Approving - L1

  • Joana Niermann removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Joana Niermann added review-approved label

    added review-approved label

  • Frank Winklmeier mentioned in commit 867f502e

    mentioned in commit 867f502e

  • Frank Winklmeier merged

    merged

  • Carlo Varni mentioned in merge request !64574 (merged)

    mentioned in merge request !64574 (merged)

    • Please register or sign in to reply