Algorithm for Global Trigger

This MR implements a new TrigGlobalEfficiencyAlg to wrap around the TrigGlobalEfficiencyCorrectionTool and obtain correct trigger SFs and matching when using single- or multi-lepton triggers (here 'lepton' = electron, muon, photon).

Tagging @jmaurer as he might want to provide feedback / suggest someone who can

thanks, neat! I'll post some comments a bit later but let me point this out to @jburr (if he isn't aware already).

I would say my main comment is that by far the majority of the work here is done to configure the global efficiency tool. If at all possible, this should be done in the python and, at the very least, it should be left as an option for the user to supply their own, fully configured, version of the tool which would be used in place of the one configured here.

I'll leave a few more specific comments inline. Obviously any about the tool initialization can be ignored if that is shifted to python.

OK - that's the lion share of my comments.

What I forgot to say in the first one is that overall it looks good - nice work! (and thanks for putting this in).

I appreciate that shifting the tool configuration into python might be a lot of work but I really think that it would be worthwhile if possible.

Jon

mentioned in merge request !64360 (merged)

added 4 commits

• 2ba470b7 - only save trigger SFs when running on MC
• 198ef66b - fixes to python syntax suggested by Jon
• 0d5e7aeb - we actually need to run on data to get the matching decision
• 4eb9d9b6 - fixes to c++ syntax suggested by Jon

Compare with previous version

added 1 commit

• 25e58717 - fix the event filter on global trigger matching

Compare with previous version

added 4 commits

• 5ed48fbc - removing getTriggerLegs, replacing it by suggestElectron/PhotonMapKeys
• 37540ad1 - update photon triggers for test
• 0858c04c - use specialised methods for making the various algorithms
• 80b6a646 - adding new property to do only the matching

Compare with previous version

marked this merge request as ready

This merge request affects 3 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/TriggerAnalysisAlgorithms
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

Affected files list will not be printed in this case

Adding @krumnack ,@tadej ,@pagessin as watchers