Skip to content
Snippets Groups Projects

Muon mdt measurement - Introduce prefix to avoid naming clash

Merged Muon mdt measurement - Introduce prefix to avoid naming clash
jojungge/athena:MuonmdtPrepData_v2 into main
All threads resolved!
Merged Johannes Junggeburth requested to merge jojungge/athena:MuonmdtPrepData_v2 into main
All threads resolved!

Hi everybody,

the adc decorator name is also booked by the xAOD::TriggerTower_v2. Unfortunately, it's not the same type as an Mdt adc. In a reconstruction job, this introduces quite a funny situation. Because sometimes, the Mdts are first created sometimes the trigger towers giving opposite exception messages. Anyhow, lesson taken, I've added a prefix to the Mdt decorators to ensure that they're unique. I don't know if anyone else has a better idea: @akraszna, @ncalace, @emoyse

Edited by Johannes Junggeburth

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • acad8f3d - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Johannes Junggeburth
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • dc452449 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • ae6c6760 - Apply 2 suggestion(s) to 2 file(s)

    Compare with previous version

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonTrkPrepDataCnv

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot added MuonSpectrometer main labels

    added MuonSpectrometer main labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ae6c6760)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74495]

  • Johannes Junggeburth changed the description

    changed the description

  • Johannes Junggeburth marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonTrkPrepDataCnv

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 5bc73ba7 - Introduce prefix to avoid naming clash

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
    • MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonTrkPrepDataCnv

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 5bc73ba7)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74516]

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 4d90f494 - account for the status name change

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
    • MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonTrkPrepDataCnv

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 4d90f494)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74519]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ae6c6760)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74515]

  • Johannes Junggeburth
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 437cbcfb - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonTrkPrepDataCnv

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 437cbcfb)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74551]

  • J
    Joana Niermann @jonierma ·
    Developer

    CI clean, changes look good from an L1 point of view. Approving - L1

  • Joana Niermann removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Joana Niermann added review-approved label

    added review-approved label

  • Vakhtang Tsulaia mentioned in commit abe2719c

    mentioned in commit abe2719c

  • Vakhtang Tsulaia merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply