Skip to content
Snippets Groups Projects

Refactoring ITk seed maker

Merged Noemi Calace requested to merge ncalace/athena:refactoring-itk-seeding into main
All threads resolved!

I have refactored the ITk seed maker to provide clear measurement of the CPU contributions. In this way, the newEvent function is used to configure the environment and retrieve the space points while the production of the map storing the connections between space points happens when the find3sp function is called, just before seed production. This allows 1:1 comparison of CPU with the ACTS version of the same code.

No changes in performance are expected (both on CPU and physics). I have tested it running RunWorkflowTests_Run4.py.

FYI: @tstreble @cvarni @lfaldaul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • removed master label

  • Thomas Strebler resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 6e32f161)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74502]

  • Just some small comments, otherwise looks good from an L1 point of view - L1

  • Noemi Calace resolved all threads

    resolved all threads

  • Noemi Calace resolved all threads

    resolved all threads

  • Noemi Calace added 1 commit

    added 1 commit

    Compare with previous version

  • Noemi Calace resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

    This merge request affects 2 files:

    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/SiSpacePointsSeedTool_xk/ITkSiSpacePointsSeedMaker.h
    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

    Adding @goetz ,@gavrilen ,@sroe ,@jsandesa as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 128K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • :white_check_mark: CI Result SUCCESS (hash e3b27849)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74584]

  • Okay, thanks. The changes look okay, have been vetted a bit, and there are no issues with the CI. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia mentioned in commit 9b6811fc

    mentioned in commit 9b6811fc

  • Thomas Strebler mentioned in merge request !64557 (merged)

    mentioned in merge request !64557 (merged)

  • Please register or sign in to reply
    Loading