Skip to content
Snippets Groups Projects

EFTrackingEmulation: added new resolution functions in URD

Merged Francesca Pastore requested to merge fpastore/athena:EFTEmuFunctions into main
All threads resolved!

Added new files obtained as explained in https://indico.cern.ch/event/1306574/#2-ef-tracking-smearing-study and updated wrt to that.

new file:   Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/d0Fitparam_N.C
new file:   Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/effFitparam_N.C
new file:   Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/ptqoptFitparam_N.C
new file:   Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/z0Fitparam_N.C

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Otherwise looks Ok - L1

  • added 1 commit

    • 701d63fc - fix on fucntions, thanks for comments; made SmearingScaleFactor as double

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/EFTracking/EFTrackingEmulation

    This merge request affects 9 files:

    • Trigger/EFTracking/EFTrackingEmulation/CMakeLists.txt
    • Trigger/EFTracking/EFTrackingEmulation/README
    • Trigger/EFTracking/EFTrackingEmulation/python/EFTrackingSmearingConfig.py
    • Trigger/EFTracking/EFTrackingEmulation/src/EFTrackingSmearingAlg.h
    • Trigger/EFTracking/EFTrackingEmulation/src/FakeTrackSmearer.h
    • Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/d0Fitparam_N.C
    • Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/effFitparam_N.C
    • Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/ptqoptFitparam_N.C
    • Trigger/EFTracking/EFTrackingEmulation/src/FitFunctions/URD/z0Fitparam_N.C
  • Thanks @jonierma for the useful comments, I resolved all of them

  • Francesca Pastore resolved all threads

    resolved all threads

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 701d63fc)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74565]

  • The changes look okay, all the suggestions have been addressed, and there are no issues with the CI. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia mentioned in commit 8d3f567e

    mentioned in commit 8d3f567e

  • Please register or sign in to reply
    Loading