add suggestPhotonMapKeys() to TrigGlobalEfficiencyCorrectionTool

These suggest*() functions are auxiliary static methods of the class that can be used to help configuring an actual tool instance. Only electrons were supported so far, this extends to photons, for !64337 (merged). The MR adds two functions, the one from the the title and a more generic suggestEgammaMapKeys() that takes an extra argument (the desired object type).

The example 4 in the package was extended to test the photon implementation.

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

This merge request affects 6 files:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/ImportData.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/TrigGlobalEfficiencyCorrectionTool.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/ImportData.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrectionTool.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/data/MapKeys.cfg
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/examples/TrigGlobEffCorrExample4.cxx

added Trigger main review-pending-level-1 labels

mentioned in merge request !64337 (merged)

CI integration tests for projects Athena,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 0a098406)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74544]

removed review-pending-level-1 label

added review-user-action-required label

added 1 commit

• e37303af - bool -> StatusCode

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

This merge request affects 6 files:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/ImportData.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/TrigGlobalEfficiencyCorrectionTool.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/ImportData.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrectionTool.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/data/MapKeys.cfg
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/examples/TrigGlobEffCorrExample4.cxx

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash e37303af)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74563]

Hi @jmaurer. There are a few compilation warnings, such as the following:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/main/Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/examples/TrigGlobEffCorrExample4.cxx:92:20: warning: Use of static expression 'quiet' of type 'bool' within function 'StatusCode testElectrons()' may not be thread-safe.
   92 |                 if(!quiet)
      |                    ^~~~~~

Can this be addressed?

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• 6da9a634 - no global variables

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

This merge request affects 6 files:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/ImportData.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/TrigGlobalEfficiencyCorrectionTool.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/ImportData.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrectionTool.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/data/MapKeys.cfg
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/examples/TrigGlobEffCorrExample4.cxx

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 6da9a634)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74586]

Just a minor style comment. Otherwise looks good.

Best, Thomas - L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 5035c759 - fix inconsistent indentation

Compare with previous version

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

This merge request affects 6 files:

• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/ImportData.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/Root/TrigGlobalEfficiencyCorrectionTool.cxx
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/ImportData.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrection/TrigGlobalEfficiencyCorrectionTool.h
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/data/MapKeys.cfg
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/examples/TrigGlobEffCorrExample4.cxx

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 5035c759)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74639]

Approving - L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 1154327b