Fix ROB prefetching configuration for probe triggers

Setting the ROBPrefetchingInputDecisions for the probe versions of the ROB prefetching algorithms that are used in purely CA based configuration (ATR-27934). Changing the check on the name of the input maker output to checking IsProbe as this is set only for the legacy configuration which is handled a bit differently (by cloning+renaming the algorithms) later on, so this now handles the non-probe (legacy and CA config) and CA configured probe versions of the ROB prefetching algorithms in one place.

Hi @sshaw , the change seems fine, but I wonder if we can even remove the full condition, and just do

for child in seqChildren:
     if hasProp(child,’ROBPrefetchingInputDecisions’)and input_maker_output not in child.ROBPrefetchingInputDecisions:
          if locked:
              child.unlock()
          child.ROBPrefetchingInputDecisions += [input_maker_output]
          if locked:
               child.lock()

It will configure the ROBPrefetching in both cases and we can remove the Input decision configuration from the signature code, and do it centrally.

resolved all threads

added 1 commit

• 242fc202 - Check IsProbe instead of convoluted algorithm/IM name checking

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 1 file:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Config/MenuComponents.py

Adding @sutt ,@shanisch ,@lidiaz as watchers

added 23.0 Trigger TriggerMenu review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 242fc202)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74575]

The change is straightforward and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 25e2fc36

mentioned in merge request !64388 (merged)