Master-R22 FudgeFactorTool setup and ECIDS removal

Updating setup of the fudge factor tool to the R22 recommended workflow, using TUNE23. Also removing ECIDS variables and related flags since ECIDS is not available in DAODs anymore.

This merge request affects 3 packages:

• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopCPTools
• PhysicsAnalysis/TopPhys/xAOD/TopSystematicObjectMaker

Affected files list will not be printed in this case

Adding @skorn ,@cgarvey ,@ravinab ,@thsteven as watchers

added Analysis AnalysisTop main review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

312K in file PhysicsAnalysis/TopPhys/xAOD/TopAnalysis/Root/EventSaverFlatNtuple.cxx

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 5c773d81)

	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74613]

Can you update the title of the MR to something a bit more descriptive, as this is what will be left in the commit history once merged? Thanks

Best, Thomas - L1

I've just shared a few comments worth to consider.

Best, Thomas - L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 3ffafa23 - Cleaning up tool setup and also using string variable for toolname

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 3 packages:

• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopCPTools
• PhysicsAnalysis/TopPhys/xAOD/TopSystematicObjectMaker

Affected files list will not be printed in this case

Adding @skorn ,@cgarvey ,@ravinab ,@thsteven as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

312K in file PhysicsAnalysis/TopPhys/xAOD/TopAnalysis/Root/EventSaverFlatNtuple.cxx

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 3ffafa23)

	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74647]

Please resolve the open threads and change the name of the MR to something more descriptive. Thanks

Setting back to review-user-action-required until then

Best, Thomas - L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 92fd0831 - removing unused variables for using and storing ECIDS

Compare with previous version

This merge request affects 3 packages:

• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopCPTools
• PhysicsAnalysis/TopPhys/xAOD/TopSystematicObjectMaker

Affected files list will not be printed in this case

Adding @skorn ,@cgarvey ,@ravinab ,@thsteven as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

312K in file PhysicsAnalysis/TopPhys/xAOD/TopAnalysis/Root/EventSaverFlatNtuple.cxx

added review-user-action-required label

removed review-pending-level-1 label

added 1 commit

• 0261bf4e - removing unused variables for using and storing ECIDS

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 3 packages:

• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopCPTools
• PhysicsAnalysis/TopPhys/xAOD/TopSystematicObjectMaker

Affected files list will not be printed in this case

Adding @skorn ,@cgarvey ,@ravinab ,@thsteven as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

312K in file PhysicsAnalysis/TopPhys/xAOD/TopAnalysis/Root/EventSaverFlatNtuple.cxx

changed the description

added review-user-action-required label and removed review-pending-level-1 label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 92fd0831)

	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74653]

changed title from Master FF to Master-R22_FudgeFactorTool_setup_and_ECIDS_removal

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 0261bf4e)

	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74655]

changed title from Master-R22{--}FudgeFactorTool{--}setup{--}and{--}ECIDS_removal to Master-R22 FudgeFactorTool setup and ECIDS removal

resolved all threads

Looks good, approving - L1

added review-approved label and removed review-user-action-required label

merged

mentioned in commit 9de56b38

mentioned in merge request !63145 (closed)