ZFinder bug fixes and option for running in jet super ROI

Added ZFinder options for jet super ROI to trigger fast track finder configuration and made some small improvements to the ZFinder code. ZFinder before fast tracking in jet super ROI can be turned on using flags.Trigger.InDetTracking.jetSuper.doZFinder=True; in --preExec options for Reco_tf.py.

It effectively reduces the ROI for FTF seeding from +-180 mm to +- 20 mm around the z-position found by the z-finder.

Two bugs in the ZFinder are fixed:

1. Spacepoint selection - an indexing bug meant that if spacepoints which don't pass the maximum layer number and ROI phi selections occured in the spacepoint vector before those that do pass the selection, zero values of phi, rho and z coordinates, and layer number, were used by the ZFinder instead of the correct values for the spacepoints. This only caused small changes to the z histograms in my tests, but sometimes resulted in the wrong z peak being selected and hence reduced tracking efficiency.
2. Vertex significance calculation - instead of adding 3 consecutive bins, it was adding the last of the 3 twice to the first bin. This was only done if MinVtxSignificance was set to a value above 0.

Tagging @lshi and @lbeemste since this affects b-jet trigger -- although the default b-jet trigger behaviour should be unchanged.

added 23.0 Trigger TriggerID TriggerJet + 1 deleted label

requested review from @sutt

This merge request affects 3 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigAnalysis/TrigInDetAnalysisUtils
• Trigger/TrigTools/IDScanZFinder

Affected files list will not be printed in this case

Adding @sutt ,@nagano ,@mvozak ,@keli as watchers

added review-pending-level-1 label

marked this merge request as draft

removed review-pending-level-1 label

thanks @mmlinare , sorry I can not find the place to config precision tracking, will you add the precision tracking in this MR or you prefer to make another one?

changed the description

added bugfix label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash bc50b160)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74654]

@mmlinare what is the z width for this ROI and can you write that in the MR description? Also is this really a bugfix, it sounds like it's adding a feature. (If this is urgent for some reason, there's the urgent flag for that)

removed bugfix label

oh, I see, @sutt requested that bugfix was added because of an indexing error somewhere in the internals. I guess it makes sense to leave that then, but also maybe add that to the description?

added bugfix label

changed the description

changed the description

changed the description

added 2 commits

• 9c77b7fa - ZFinderConstants documentation fix
• a400a5f9 - Reverted change to default m_tripletDK value in ZFinder and added new variable...

Compare with previous version

added 1 commit

• 0b2cab78 - Added halving triplet DK value to ZFinder initialization

Compare with previous version

added 1 commit

• 31dad774 - Added halving triplet DK value to ZFinder initialization

Compare with previous version

added 1 commit

• 33afaf99 - Fixed spacepoint selection bug in ZFinder

Compare with previous version

removed 1 deleted label

changed title from Draft: ZFinder for jet super ROI to Draft: ZFinder bug fixes and option for running in jet super ROI

changed the description

Jenkins please retry a build

This merge request affects 3 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigAnalysis/TrigInDetAnalysisUtils
• Trigger/TrigTools/IDScanZFinder

Affected files list will not be printed in this case

Adding @sutt ,@nagano ,@mvozak ,@keli as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 33afaf99)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75798]

marked this merge request as ready

This merge request affects 3 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigAnalysis/TrigInDetAnalysisUtils
• Trigger/TrigTools/IDScanZFinder

Affected files list will not be printed in this case

Adding @sutt ,@nagano ,@mvozak ,@keli as watchers

added review-pending-level-1 label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.