MuonHoughTools - Fix out of bound access FPE in cosmic reconstruction

Closes ATR-27137

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @apsallid ,@goetz ,@rosati ,@salderwe ,@pscholer ,@martindl ,@stavrop ,@okumura ,@vmartin ,@jojungge as watchers

added 23.0 MuonSpectrometer Trigger review-pending-level-1 labels

@jcatmore, @nstyles FPE fixes still allowed in 23.0

resolved all threads

CI Result SUCCESS (hash dd213118)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74671]

The changes look okay and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

resolved all threads

resolved all threads

resolved all threads

resolved all threads

resolved all threads

added 1 commit

• 15ebe959 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @apsallid ,@goetz ,@rosati ,@salderwe ,@pscholer ,@martindl ,@stavrop ,@okumura ,@vmartin ,@jojungge as watchers

added review-pending-level-1 label and removed review-approved review-approved-tier0 labels

resolved all threads

added 1 commit

• 716cac6c - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @apsallid ,@goetz ,@rosati ,@salderwe ,@pscholer ,@martindl ,@stavrop ,@okumura ,@vmartin ,@jojungge as watchers

CI Result SUCCESS (hash 15ebe959)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74742]

added review-approved-point1 label

CI Result SUCCESS (hash 716cac6c)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74743]

There's been a bit of discussion about the changes already, they look okay (modulo magic numbers), and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

@jojungge - how relevant is this for P1. The jira says about ART tests. But I guess we have the same issues while running online? (Is this code running online at all?) The test mentioned there is trigger one but the log is RAWtoALL so I am not sure.

added review-approved-tier0 label

It's run in the cosmic reconstruction. Whether this is run in the trigger or not, I have 0 clue. Merge it or close it.

resolved all threads

merged

mentioned in commit ea4bc8cc

mentioned in merge request !64541 (merged)