Change IBeamIntensity API to take run and event number explicitly

• The IBeamIntensity API now takes the run and event number explicitly.
• StepArrayBM and ArrayBM now use ContextSpecificData for the t0 offset. SlotSpecificObj is not used because this also needs to work when there is no valid context
• ArrayBM now has a Seed property. If this is set to a non-zero value, it uses FastReseededPRNG seeded with this value and the run and event number instead of the AthRNGSvc
• FastReseededPRNG has been added to CxxUtils. For now xxhash is vendored, until it can be added to externals or the LCG release

added 1 commit

• 1deb2afa - Use one persistent discrete_distribution in ArrayBM

Compare with previous version

added 1 commit

• cf8f96ca - Use Boost.Random discrete_distribution

Compare with previous version

added 14 commits

• cf8f96ca...e348324b - 8 commits from branch atlas:main
• c53c7739 - Add FastReseededPRNG to CxxUtils
• 2647479d - Modify IBeamIntensity API to take run / evt num explicitly
• fa6d44fa - Fix errors
• 7b5766d1 - Use ContextSpecificData for t0 offsets
• c1e9fb37 - Use one persistent discrete_distribution in ArrayBM
• 8420eb74 - Use Boost.Random discrete_distribution

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 4 packages:

• Control/CxxUtils
• Control/PileUpComps
• Control/PileUpMT
• Control/PileUpTools

Affected files list will not be printed in this case

Adding @ssnyder ,@rbianchi as watchers

added Core Digitization main review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

240K in file Control/CxxUtils/Root/xxhash.h

CI Result SUCCESS (hash 8420eb74)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74838]

added 1 commit

• 26a8d690 - Stop forcing batches to be unloaded in order

Compare with previous version

This merge request affects 4 packages:

• Control/CxxUtils
• Control/PileUpComps
• Control/PileUpMT
• Control/PileUpTools

Affected files list will not be printed in this case

Adding @ssnyder ,@rbianchi as watchers

WARNING: big files (>100K) are found in the changeset

240K in file Control/CxxUtils/Root/xxhash.h

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 26a8d690)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74850]

added 1 commit

• 792ccb04 - Fix error

Compare with previous version

This merge request affects 4 packages:

• Control/CxxUtils
• Control/PileUpComps
• Control/PileUpMT
• Control/PileUpTools

Affected files list will not be printed in this case

Adding @ssnyder ,@rbianchi as watchers

WARNING: big files (>100K) are found in the changeset

240K in file Control/CxxUtils/Root/xxhash.h

CI Result SUCCESS (hash 792ccb04)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74855]

In general, changes look fine and the CI is good. Sending on to L2 due to the size of the MR. Clara (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added 101 commits

• 792ccb04...c607fda0 - 93 commits from branch atlas:main
• adeb8cbf - Add FastReseededPRNG to CxxUtils
• 2a790281 - Modify IBeamIntensity API to take run / evt num explicitly
• b745ece6 - Fix errors
• f358cf07 - Use ContextSpecificData for t0 offsets
• 7cc20647 - Use one persistent discrete_distribution in ArrayBM
• 6a930a94 - Use Boost.Random discrete_distribution
• 54d8b937 - Stop forcing batches to be unloaded in order
• 77808a6c - Fix error

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 4 packages:

• Control/CxxUtils
• Control/PileUpComps
• Control/PileUpMT
• Control/PileUpTools

Affected files list will not be printed in this case

Adding @ssnyder ,@rbianchi as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

WARNING: big files (>100K) are found in the changeset

240K in file Control/CxxUtils/Root/xxhash.h

CI Result FAILURE

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake	N/A	N/A	N/A	N/A	N/A	N/A
make	N/A	N/A	N/A	N/A	N/A	N/A
tests	N/A	N/A	N/A	N/A	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74914]

Jenkins please retry a build

This merge request affects 4 packages:

• Control/CxxUtils
• Control/PileUpComps
• Control/PileUpMT
• Control/PileUpTools

Affected files list will not be printed in this case

Adding @ssnyder ,@rbianchi as watchers

WARNING: big files (>100K) are found in the changeset

240K in file Control/CxxUtils/Root/xxhash.h

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result FAILURE (hash 77808a6c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74919]

CI looks clean, except for known ACTS issue, already was reviewd by L1, resetting L2 label after CI trigger. - L1

removed review-pending-level-1 label

added review-pending-level-2 label

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit efa8a468