ATR-27964 Support removed TriggerTowers with zero energy in MC L1Calo sim

This MR is meant to solve ATR-27964. Warning are popping up because we are running on MC instead of Data. The TriggerTowers are done using the Run2TriggerTowerMakerCfg and it removes all Towers with et=0 energy.. and therefore not found in the container. Added the Gaudi boolean property to specify to the algo if it is Data or MC and print or not the WARNING accordingly. Warning is important for data since the TTs should be always present!

@tbold @tamartin @martindl

added Run3L1Calo urgent labels

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 2 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jTowerMakerFromJfexTowers.h

Adding @thompson ,@serodrig as watchers

added 23.0 Trigger review-pending-level-1 labels

changed title from solving ATR-27964 to reverting changes. ATR-27964

removed 23.0 Trigger review-pending-level-1 labels

added 23.0 Trigger review-pending-level-1 labels

Thanks @serodrig - though you will need to revert the count changes too. Easier to use the revert button on the original MR?

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 8c4984a0)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74782]

CI clean, changes are OK from an L1 point of view, but there is still an open question in the discussion. - L1

removed review-pending-level-1 label

added review-user-action-required label

resolved all threads

resolved all threads

added review-pending-level-1 label and removed review-user-action-required label

All threads resolved, approving- L1

removed review-pending-level-1 label

added review-approved label

I already have the fix for the problem. I open the thread to stop the merging

changed title from reverting changes. ATR-27964 to Solving ATR-27964

changed the description

resolved all threads

added 1 commit

• a33e4bcf - Fixing ATR-27964

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added review-pending-level-1 label and removed review-approved label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash a33e4bcf)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74795]

CI clean, new changes also look Ok. Approving again - L1

removed review-pending-level-1 label

added review-approved label

resolved all threads

changed title from Solving ATR-27964 to ATR-27964 Support removed TriggerTowers with zero energy in MC L1Calo sim

mentioned in merge request !64420 (merged)

mentioned in commit 7901c383

merged

resolved all threads

mentioned in merge request !64541 (merged)