23.0 Fix TRT DriftCircles for cosmics

Removes a superfluous check of permanent straw status, which drops all valid drift circles.

Fixes ATLASRECTS-7565 and ATLASDQ-1100.

added urgent label

mentioned in merge request !64471 (closed)

This merge request affects 1 package:

• InnerDetector/InDetRecTools/TRT_DriftCircleTool

This merge request affects 1 file:

• InnerDetector/InDetRecTools/TRT_DriftCircleTool/src/TRT_DriftCircleToolCosmics.cxx

Adding @cgrefe ,@calfayan ,@gavrilen ,@sroe ,@goetz as watchers

added 23.0 InnerDetector review-pending-level-1 labels

Copy of !64471 (closed) targeting 23.0

CI Result SUCCESS (hash 3e6af409)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74819]

Changes look fine and the CI is good. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 0a50a40b

merged

I today's TCT tests, the following items changed wrt to yesterday:

InDet::TRT_DriftCircleContainer_p2_TRT_DriftCircles:
   [m_collections.m_hashId, m_collections.m_size, m_prdDeltaId, m_rawdata.m_TRTdata, m_rawdata.m_errMat, m_rawdata.m_locPos]: differences in 6 data tests

(ESD only). So this MR is output-changing, is this expected?

• Walter

This change adds back the TRT drift circles for cosmic reconstruction which were missing before.

Presumably the differences are only in a cosmics test, otherwise this would be a bit surprising? (we shouldn't be using this cosmics-specific tool for other configurations I hope).

Indeed. The changes are also visible in tests processing data22_calib, but those are effectively reconstructed as cosmics.

mentioned in merge request !64541 (merged)