Skip to content
Snippets Groups Projects

Further unification of TruthHelpers functions

Merged Further unification of TruthHelpers functions
averbyts/athena:truthutils2 into main
All threads resolved!
Merged Andrii Verbytskyi requested to merge averbyts/athena:truthutils2 into main
All threads resolved!

Further unification of TruthHelpers functions:

  • use !isSumulationparticle instead of is_truthhelper_generator_particle
Edited by Andrii Verbytskyi

Merge request reports

Pipeline #5932334 passed

Stage: external

    Pipeline passed for b071b403 on averbyts:truthutils2

    Approval is optional

    Merged by Edward MoyseEdward Moyse 1 year ago (Jul 23, 2023 7:14am UTC)

    Merge details

    • Changes merged into main with ef50f0ba (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Changing label to review-user-action-required until the discussion is resolved. Clara (L1)

  • Clara Nellist added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Andrii Verbytskyi added 32 commits

    added 32 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Generators/FlowAfterburner
    • Generators/TruthUtils
    • PhysicsAnalysis/D3PDMaker/egammaD3PDAnalysis
    • PhysicsAnalysis/TruthParticleID/McParticleTools

    Affected files list will not be printed in this case

    Adding @zmarshal as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects Athena are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 68f41c57)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74922]

  • Andrii Verbytskyi added 8 commits

    added 8 commits

    Compare with previous version

  • Andrii Verbytskyi resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Generators/FlowAfterburner
    • Generators/TruthUtils
    • PhysicsAnalysis/D3PDMaker/egammaD3PDAnalysis
    • PhysicsAnalysis/TruthParticleID/McParticleTools

    Affected files list will not be printed in this case

    Adding @zmarshal as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects Athena are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash a0cddaa8)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74942]

  • Andrii Verbytskyi added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Generators/FlowAfterburner
    • Generators/TruthUtils
    • PhysicsAnalysis/D3PDMaker/egammaD3PDAnalysis
    • PhysicsAnalysis/TruthParticleID/McParticleTools

    Affected files list will not be printed in this case

    Adding @zmarshal as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash b071b403)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74985]

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Changes look fine. The error which was causing the failure has been resolved. Approving. Clara (L1)

  • Clara Nellist added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit ef50f0ba

    mentioned in commit ef50f0ba

    • Please register or sign in to reply