gFex Simulation Updates

With this MR, the following changes have been made:

• the gFex simulation has been updated to arrange the forward input as in firmware (changes in gFEXFPGA and gFEXSim tools)
• the gTowerMakerFromGfexTowers tool is introduced to build gTower objects from the readout gTowers, to be used as input to the gFEX simulation and to obtain emulated trigger objects as output (see similar implementation for jFEX !63254 (merged))
• note that if the readout gTowers are not available (but they should be always available in data by default), CaloCell/TriggerTower containers filled with readout SuperCells/Tile towers are used instead;
• the gFexDriver and FexReprocessingRun3 have been updated consequently;
• the conversion from the simulation ID to the firmware ID for the gTowers has been moved into the gTower class.

This merge request affects 3 packages:

• Event/xAOD/xAODTrigL1Calo
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@akraszna ,@serodrig as watchers

added 23.0 EDM JetEtmiss Trigger analysis-review-required review-pending-level-1 labels

CI Result FAILURE (hash 3230afe6)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75015]

Hi @ctosciri. For some reason it seems the CI pipeline status isn't displaying correctly in some places. Can you please check that you've added atlasbot as a developer to your fork as described here?

If the bot is already added, then can you check that your fork is not set to private? If it's private the CI status may not display correctly.

Thanks.

Hi @ctosciri. One of the tests is failing with the following:

chainComp ERROR    Trigger counts differ from the reference. If the above differences are intended, update the reference

Is this intended?

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

Jenkins please retry a build

This merge request affects 3 packages:

• Event/xAOD/xAODTrigL1Calo
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@akraszna ,@serodrig as watchers

added review-pending-level-1 label and removed review-user-action-required label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result FAILURE (hash 3230afe6)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75681]

added 1 commit

• a8c5d5ae - Update trigger counts

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODTrigL1Calo
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @vmartin ,@martindl ,@akraszna ,@serodrig ,@thompson ,@okumura as watchers

added changes-trigger-counts label

WARNING: big files (>100K) are found in the changeset

436K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

CI Result SUCCESS (hash a8c5d5ae)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75690]

Hello @ctosciri , I left a few comments.

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 7a28d253 - Address MR comments

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODTrigL1Calo
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @vmartin ,@martindl ,@akraszna ,@serodrig ,@thompson ,@okumura as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

436K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

resolved all threads

CI Result SUCCESS (hash 7a28d253)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75731]

resolved all threads

In general, changes look fine to me and the CI is good. There's one section of commented out code that could be considered for removal. Sending on to L2 due to the size. Clara (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added 1 commit

• a901b487 - Clean up

Compare with previous version

resolved all threads

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 4 packages:

• Event/xAOD/xAODTrigL1Calo
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @vmartin ,@martindl ,@akraszna ,@serodrig ,@thompson ,@okumura as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

WARNING: big files (>100K) are found in the changeset

436K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

resolved all threads

CI Result SUCCESS (hash a901b487)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75750]

All threads have been resolved and the CI is good. Sending back to L2 for a final check. Clara (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Thanks @ctosciri - the https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/gTowerContainer.h is only used transiently to pass data between algorithms, right?