Skip to content
Snippets Groups Projects

MuonGeometryR4 - Introduce the MuonStationGeoHelpers package

Merged Johannes Junggeburth requested to merge jojungge/athena:GeoHelpers into main
All threads resolved!

The station geo helpers provide for each muon chamber a reference coordinate system which is the baseline for the hough seeding and segment finding in the run 4 muon reconstruction. The position of the system is the the plane that's on the bisect between the first tube layer in the lower multilayer and the last tube layer in the upper multilayer of each Mdt chamber.

  • MuonTransformCache*: Add documentation and an additional getter function
  • MdtReadoutElement*: The transformation to the layer center points now to the exact center of the layer. Orientation still not changed w.r.t. the tube coordinate system (I.e. z-axis along the wire, x-axis pointing to the next layer, and y-axis going along the tube number)
Edited by Johannes Junggeburth

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Tadej NovakTadej Novak 1 year ago (Aug 2, 2023 8:34am UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Also forwarding to L2 to look at the new headers - L1

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • added 1 commit

    • 80a219a5 - Apply 4 suggestion(s) to 3 file(s)

    Compare with previous version

  • This merge request affects 3 packages:

    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonStationGeoHelpers

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • :white_check_mark: CI Result SUCCESS (hash 80a219a5)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75489]

  • added ACTS label

  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Tadej Novak mentioned in commit c74040b3

    mentioned in commit c74040b3

  • merged

  • Please register or sign in to reply
    Loading