Skip to content

Add a flag to control JiveXML output, add CA configuration

Edward Moyse requested to merge emoyse/athena:23.0-move-JiveXML-to-CA into 23.0

JiveXML config needs to be migrated to CA. As for why this is targetting 23.0, see the discussion here on the original MR !64668 (closed) (TL;DR: @lshi and @myexley want to include JiveXML in the test at P1 while setting up the online reconstruction in CA).

This is not complete (see TODOs and FIXMEs in the code) but since this is all new configuration (and the old configuration remains) it is not running in any workflow and so being incomplete does not matter. And I am about to go on holiday and maybe @lshi or @myexley will have time to complete the missing sections (especially Calo) in the meantime.

One thing I have done is separate the filling of data_types from setting up the receivers. In a way this is a bit awkward since they are very tightly coupled, but for the CA configuration we wanted to avoid post-config fiddling ... i.e. we should not configure the JiveXML algo, then add the data_types much later. Probably there would have been other nice solutions, but this is the way I went (and I don't think it matters too much what the exact solution is)

I have also not done a one-to-one migration - in some cases the old configuration seemed over complicated and so I made simplifications. We could probably do more, by ensuring the cpp defaults match the current configuration, and then just relying on these defaults.

I tested it with the following command:

Reco_tf.py --CA --preExec="flags.Output.doJiveXML=True" --maxEvents 1 --inputRDOFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/PhaseIIUpgrade/RDO/ATLAS-P2-RUN4-03-00-00/mc21_14TeV.601229.PhPy8EG_A14_ttbar_hdamp258p75_SingleLep.recon.RDO.e8481_s4149_r14700/RDO.33629020._000047.pool.root.1 --outputESDFile myESD.pool.root > log.out
Edited by Edward Moyse

Merge request reports