Revert to legacy HI jet trigger config

!61235 (merged) prematurely made use of a CA-based HI jet trigger configuration that was not quite ready. Addressing ATR-28055, this MR restores the legacy HI jet trigger configuration, which we would need to use for the HI run and preparatory reprocessings. The CA config can be reenabled when it is better validated.

Along the way I switched all the JetHIConfig Configurable setup to use CompFactory, to permit reusing this code for the CA setup if necessary.

Attn @asmaga, @mrybar. Martin, I hope I didn't conflict with what you were working on already -- would be happy to drop the CompFactory commit if preferred.

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 3 files:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetChainConfiguration.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetHIConfig.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetHISequences.py

Adding @sutt ,@miochoa ,@lidiaz ,@cantel as watchers

added 23.0 JetEtmiss Trigger TriggerMenu review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 39fa343f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75718]

mentioned in merge request !64788 (merged)

added 34 commits

• 39fa343f...5a420447 - 30 commits from branch atlas:23.0
• 7c580dee - Reinstate legacy-steered HI configuration
• 7a4bacc1 - Switch from explicit Conf import to CompFactory in HI jet config
• 27351d1e - Cleanup
• 6be1b653 - Correct imports

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 3 files:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetChainConfiguration.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetHIConfig.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetHISequences.py

Adding @sutt ,@miochoa ,@lidiaz ,@cantel as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 6be1b653)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75749]

Changes look good to me and the CI is green. Sending on to L2 for a second look before sign-off. Clara (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added review-user-action-required label and removed review-pending-level-2 label

Hi @cvarni, how strongly do you feel about all the proposed changes? I was trying to avoid any modifications to the original code, which was deleted in !61235 (merged), and we hope to remove it again soon.

not strong opinion, they are just minor comments. Feel free to address them or close them, especially if this code will be removed in the next future

added 1 commit

• b604d150 - L2 reviewer suggestions

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 3 files:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetChainConfiguration.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetHIConfig.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetHISequences.py

Adding @sutt ,@miochoa ,@lidiaz ,@cantel as watchers