AthenaConfiguration: fix orphaned tools in legacy support

When renaming a configurable one needs to ensure to also set the _jobOptName slot (where available). Otherwise this leads to orphaned configurables instances without a parent. These do not create a problem but appear needlessly in the final pickle file.

Also ensure that the global Configurable DB is adjusted correctly after renaming.

added full-unit-tests label

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/LegacySupport.py

Adding @gemmeren ,@ssnyder ,@maszyman as watchers

added 23.0 Core analysis-review-required review-pending-level-1 labels

added NewConfig label

CI Result SUCCESS (hash 03c91419)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75784]

Changes look fine and the CI is good. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

removed analysis-review-required label

added review-approved-tier0 label

mentioned in commit 769019b9

merged

mentioned in merge request !64854 (merged)