Solve a problem with fwd seeding in jJ

This MR was to changed the jJ seeding for the FWD algorithm, the condition to correct the jet with the upper-left tower was wrongly written, instead of an OR logic gate must be AND logic gate

added Run3L1Calo label

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 5 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/jFEXForwardJetsAlgo.h
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXFPGA.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXForwardJetsAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXSmallRJetAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jTowerMakerFromJfexTowers.cxx

Adding @thompson ,@serodrig as watchers

added 23.0 JetEtmiss Trigger review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 44987ef5)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75850]

Hi Sergi,

Following tests are failed after your changes CITest_Trigger_athenaHLT_v1Dev-test, CITest_TriggerMC-test

Is this tests behavior expected?

Dmitriy (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 6ba43454 - updating ref.

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @vmartin ,@salderwe ,@martindl ,@thompson ,@okumura ,@serodrig as watchers

added changes-trigger-counts review-pending-level-1 labels and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

248K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

436K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 6ba43454)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75894]

Sorry but I have another question, most of your changes is code reformatting, and I didn't see where is code changes that gives changes to output? Dmitriy (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 44464428 - L1 comment

Compare with previous version

resolved all threads

This merge request affects 3 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @vmartin ,@salderwe ,@martindl ,@thompson ,@okumura ,@serodrig as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

248K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

436K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 44464428)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75945]

All discussions resolved, CI successful, approving.

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added review-approved-tier0 label

merged

mentioned in commit b21088b7

mentioned in merge request !64944 (merged)