L1CaloFEXSim: cleanup unused headers

Hello,

This MR is mostly dropping headers that are not used, in the eFEX domain. Some side changes are made to prepare for algorithm re-entrancy (e.g. turn methods to const). More to come, I submit this batch not to make the MR too big.

Cheers, Bertrand

changed the description

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added 23.0 Trigger review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 9771a3bc)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75936]

Hi, I left two minor comments on unused funcitons/code, could yuou please take a look at them?

Thanks!

Cheers,

Francisco Sili (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 615b0f75 - address comments from MR review

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 615b0f75)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76026]

resolved all threads

All discussions resolved, CI successful, approving. Dmitriy (L1)

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label