gFexDriver Clean Up

This MR is meant to clean up the gFexDriver algorithm, and solve the error reported in ATR-28066, also discussed in !64533 (comment 7007367).

The m_gSuperCellTowerMapperTool that was wrongly called in the gFexDriver has now been removed, and there is no need to configure it in the L1CaloFEXSimCfg.py, anymore (removing Sergi's fix in !64938 (merged)).
Also, the gTowerContainer was wrongly saved to SG in both the gFEXDriver and the gTowerMakerFromGfexTowers. Now the container is only saved in gTowerMakerFromGfexTowers.

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 4 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/gFEXDriver.h
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/gTowerMakerFromGfexTowers.h
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/gFEXDriver.cxx

Adding @thompson ,@serodrig as watchers

added 23.0 Trigger review-pending-level-1 labels

mentioned in merge request !64533 (merged)

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 635daaef)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76129]

Hi @ctosciri - super, thanks for the clean-up!

added Run3L1Calo label

Thanks @ctosciri ^^

Significant clean up! :)

There are probably more developments expected here, so please don't forget to update copyright in modified files later.

Dmitriy (L1)

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added review-approved-tier0 label

mentioned in commit 7ade8e6b

merged

mentioned in merge request !64981 (merged)