Skip to content

mostly a rewrite of LArRODMonAlg

Walter Lampl requested to merge wlampl/athena:LArDSPMon into 23.0

This MR largely rewrites the LArRODMonAlg, the utility to compare LAr Cell energy/time/quality computed by the DSP vs offline.

  • Reorganize class methods. most of the complexity of this code comes from it's ability to dump all ingredients of the pulse-shape reconstruction into text files (and/or log output). This is indeed a useful debugging but very rarely used. Moved that to separate methods.
  • Use vector<pair<..>> as properties instead of 24 separate properties to describe the expected precision of the DSP calculations in given energy ranges.
  • Fix a number of mistakes that seems to have occurred in the Tool-to-Alg-migration, in particular the expected precision of time-calculation and formatting of dump-files.
  • The DSP and the offline use slightly different cuts to allow the calculation of peak-time and quality-factor, leading to spurious errors if one of them is 0. This MR suppresses these errors.

cc @ekay

Merge request reports