FTF seeding improvements

The main change is increasing the z vertex resolution for seeding based on vertices found by the ZFinder to from 20 mm to 150 mm for endcap layers only, and only in the jetSuper configuration. The attached plot shows that this increases the FTF tracking efficiency for tracks coming from b-hadron decays at around

|η|=2

to about the same level as without using the ZFinder, for a

t\bar{t}

sample.

Seeding using the ZFinder is still not the default in the jetSuper configuration; it's only used when flags.Trigger.InDetTracking.jetSuper.doZFinder=True, so this does not affect any default configuration.

There are also small improvements which should slightly reduce the CPU cost and memory usage of the seeding in all configurations, both with and without the ZFinder, and improve readability. The most significant one is probably bringing the processing of spacepoints from adjacent phi slices when the ZFinder is used in line with how it's done without the ZFinder: using m_phiThreeSlices instead of looping over the phi slices in createSeeds().

Tagging b-jet trigger coordinators @lshi and @lbeemste and ID trigger coordinators @sutt and @keli

added 23.0 Trigger TriggerID TriggerJet labels

requested review from @sutt

changed the description

changed the description

changed the description

Hi, I think that Dmitry would need to take a look at these as well. Perhaps 150 is rather too wide, as it is almost the full 180 mm that is used by default, so this would be largely equivalent to only using the ZFinder for barrel seeds so there be other ways to do this. If Dmitry is happy with the changes, then as they are diabled by default, then we might include them.

requested review from @demelian

Jenkins please retry a build

This merge request affects 3 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigTools/IDScanZFinder
• Trigger/TrigTools/TrigInDetPattRecoTools

Affected files list will not be printed in this case

Adding @sutt ,@nagano ,@keli as watchers

WARNING: big files (>100K) are found in the changeset

144K in file Trigger/TrigAlgorithms/TrigFastTrackFinder/src/TrigFastTrackFinder.cxx

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 059bd452)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76232]

added 1 commit

• 65290a5a - Variable redeclaration bug fix

Compare with previous version

Jenkins please retry a build

This merge request affects 3 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigTools/IDScanZFinder
• Trigger/TrigTools/TrigInDetPattRecoTools

Affected files list will not be printed in this case

Adding @sutt ,@nagano ,@keli as watchers

WARNING: big files (>100K) are found in the changeset

144K in file Trigger/TrigAlgorithms/TrigFastTrackFinder/src/TrigFastTrackFinder.cxx

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 65290a5a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76246]