TrigT1TGC - Clean up unused enumeration and classes and fix the wrong number of enum members (for ATR-28056)

Cleaned up unused enumeration in TGCNumbering.h and unused classes in TrigT1TGC. Moreover, the wrong number of enum members is fixed, which ATR-28056 pointed out.

This merge request affects 1 package:

• Trigger/TrigT1/TrigT1TGC

This merge request affects 38 files. Since this is a long list, it will not be printed.

Adding @junpei ,@serodrig as watchers

added Egamma Trigger main review-pending-level-1 labels

CI Result FAILURE (hash c86c6f2a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76411]

marked this merge request as draft

added 1 commit

• 7c018d7f - fix the wrong incrementation of enum class

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• Trigger/TrigT1/TrigT1TGC

This merge request affects 38 files. Since this is a long list, it will not be printed.

Adding @junpei ,@serodrig as watchers

CI Result SUCCESS (hash 7c018d7f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76449]

This should probably go in 23.0?

removed review-pending-level-1 label

added review-user-action-required label

added 23.0 label

removed 23.0 label

added 126 commits

• 7c018d7f...bf5363b0 - 82 commits from branch atlas:main
• bf5363b0...cee7ea34 - 34 earlier commits
• 06acb273 - Merge branch 'cost-post-only-md' into '23.0'
• 0daf842d - TrigValTools and TrigInDetValidation: update ART test RDOs to MC23c
• 3e49e2f9 - Merge branch '23.0_TrigARTupdate' into '23.0'
• ee8977d4 - Update Projects/AthDataQuality/version.txt,...
• f3d2e73f - Provide interface to prevent merging of some histograms; use std::regex
• bfe263e9 - Merge branch '23.0-dq-hist-merge' into '23.0'
• 73f66a26 - Split decoding and processing in Run 2 and Run 3 ZDC reconstruction algorithms (& several fixes)
• 5fcb4c1d - Merge branch 'zdc-main-23-algsplit' into '23.0'
• 19c81d72 - clean up unused enumeration and classes, fix the wrong number of enum members, etc.
• 823dcea1 - fix the wrong incrementation of enum class

Compare with previous version

changed target branch from main to 23.0

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigT1/TrigT1TGC

This merge request affects 38 files. Since this is a long list, it will not be printed.

Adding @junpei ,@serodrig as watchers

added 23.0 review-pending-level-1 labels and removed review-user-action-required label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash 823dcea1)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76475]

removed main label

resolved all threads

There are no issues with the CI and the changes look okay but are extensive, so passing to L2 for comment.

-- James for L1

added review-pending-level-2 label and removed review-pending-level-1 label

Looks fine to me as well, approving....

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

added review-approved-tier0 label

added review-approved-point1 label

merged

mentioned in commit 3d5e7767

mentioned in merge request !65151 (merged)