Skip to content
Snippets Groups Projects

Porting MUON1 to component accumulator

Merged James Catmore requested to merge jcatmore/athena:main-MUON1_CA into main

ATLASMCP-180

This MR provides a port of the MUON1 derivation to the component accumulator. It is intended that this will be used as a template for the other MCP derivations. As well as the main config fragment, the MR also provides several new config fragments for certain common tools that haven't been previously provided.

Note that the per-event content (slimming) is set the same as for PHYS so currently none of the muon-specific decorations will appear in the output. Since the configuration of this will most likely be shared with other formats, the muon performance team may choose to factor out some of the tools with common settings into a separate config script to make it easier to keep things in synch (e.g. as is done with the thinning tools between PHYS and PHYSLITE).

This MR has no impact on any ongoing production since it is a new format, and it is not used anywhere else. To make validation and fine-tuning by MCP easier, I think we should now merge this rather than trying to do it all via feature branches.

Edited by James Catmore

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • James Catmore added 4 commits

    added 4 commits

    • 48e13c59 - Fix few configuration issues
    • 00c6bf28 - Turn the DiMuonTaggingTool into an algorithm
    • 80ff2489 - Use AnalysisMuonThinningAlg.. Clean up the configuration a bit
    • 2d40d579 - Merge branch 'main-MUON1_CA' into 'main-MUON1_CA'

    Compare with previous version

  • James Catmore changed the description

    changed the description

  • removed main label

  • James Catmore marked this merge request as ready

    marked this merge request as ready

  • James Catmore changed title from Draft: porting MUON1 to component accumulator to Porting MUON1 to component accumulator

    changed title from Draft: porting MUON1 to component accumulator to Porting MUON1 to component accumulator

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons

    Affected files list will not be printed in this case

    Adding @zmarshal ,@jcatmore ,@abarton ,@apsallid ,@emmat ,@calpigia ,@mvanadia ,@wwalko ,@nicolaid as watchers

  • James Catmore resolved all threads

    resolved all threads

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 2d40d579)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77088]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading