Skip to content
Snippets Groups Projects

Jet config block fixes for R22

Merged Teng Jian Khoo requested to merge khoo/athena:ftag-vr-config into main

FTag for VR jets

The R22 calib file and settings for VR track jets are only compatible with the 'legacy' CDI file set in this MR. We have no more use for R21 recommendations. The container name hacks are also not relevant.

However, the functional CDI file refers to a track jet container name that omits 'PV0', so we need to substitute that.

Large R jets

The ConfigBlock __init__ needs to be called with the container name to pass the makeConfig assert. Evidently not being tested.

Edited by Teng Jian Khoo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • MR looks fine from L1 point of view. Just one small comment about a reference for a twiki in a comment. @khoo Can you clarify whether this reference is intended?

    Setting review-user-action-required

    Cheers, Steffen (L1)

  • Teng Jian Khoo resolved all threads

    resolved all threads

  • Teng Jian Khoo added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading