Jet config block fixes for R22
FTag for VR jets
The R22 calib file and settings for VR track jets are only compatible with the 'legacy' CDI file set in this MR. We have no more use for R21 recommendations. The container name hacks are also not relevant.
However, the functional CDI file refers to a track jet container name that omits 'PV0', so we need to substitute that.
Large R jets
The ConfigBlock __init__
needs to be called with the container name to pass the makeConfig
assert. Evidently not being tested.
Merge request reports
Activity
added Analysis analysis-review-required main review-pending-level-1 labels
added 1 commit
- 9e326dc5 - Correctly initialise LargeRJetAnalysisConfig
added JetEtmiss label
removed JetEtmiss label
CI Result SUCCESS (hash b613637b)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76703] CI Result SUCCESS (hash 9e326dc5)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76707]added analysis-review-approved label and removed analysis-review-required label
- Resolved by Teng Jian Khoo
MR looks fine from L1 point of view. Just one small comment about a reference for a twiki in a comment. @khoo Can you clarify whether this reference is intended?
Setting review-user-action-required
Cheers, Steffen (L1)
removed review-pending-level-1 label
added review-user-action-required label