Add status to transient TrackRecord class and add, but not use a new persistent class

This merge request updates the TrackRecord to include the GenParticle status. I haven't entirely decided whether this change is needed yet, so keeping it as draft for now.
Currently the value of status is not persistified, but if we switch to writing TrackCollection_p3 by default then it would be.
This merge request includes some of @averbyts's changes from !64845 (closed).

Tagging @averbyts and @pclark

added 1810 commits

• c5b16a68...c77e0630 - 1808 commits from branch atlas:main
• 5eccca50 - Add status to transient TrackRecord class and add, but not use a new persistent class
• 716945d9 - Fix compilation failures - still need to ensure that status is set correctly in TrackBarcodeInfo

Compare with previous version

added 2445 commits

• 716945d9...4e88b597 - 2443 commits from branch atlas:main
• 6db2100f - Add status to transient TrackRecord class and add, but not use a new persistent class
• b0feb4b2 - Fix compilation failures - still need to ensure that status is set correctly in TrackBarcodeInfo

Compare with previous version

added 1 commit

• 738fc022 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 41 commits

• 738fc022...f8cd647a - 32 commits from branch atlas:main
• 5ae114d0 - Update classes in MCTruth package to handle Status and UniqueID (part of...
• 33767733 - Drop unnecessary includes of MCTruth/TrackBarcodeInfo.h
• a55a2fd3 - PrimaryParticleInformation - add GetUniqueID method and drop unused SuggestBarcode method
• 0fcf8df8 - Update TrackBarcodeInfo constructor to take uniqueID as well as barcode +...
• b30b2df2 - Add parentUniqueID method to TruthIncidents
• 95b07aba - Add ISFParticle::id() method
• 99f5be82 - Add status to transient TrackRecord class and add, but not use a new persistent class
• e24a35a4 - Fix compilation failures - still need to ensure that status is set correctly in TrackBarcodeInfo
• 8d3827dc - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 12 commits

• 8d3827dc...e383f055 - 4 commits from branch atlas:main
• 638002ee - Update classes in MCTruth package to handle Status and UniqueID (part of...
• 6f0fc274 - Drop unnecessary includes of MCTruth/TrackBarcodeInfo.h
• 341c9ce5 - PrimaryParticleInformation - add GetUniqueID method and drop unused SuggestBarcode method
• b28a9b4f - Update TrackBarcodeInfo constructor to take uniqueID as well as barcode +...
• 66c60bb4 - Add parentUniqueID method to TruthIncidents
• 1543947b - Add ISFParticle::id() method
• ac58264c - Add status to transient TrackRecord class and add, but not use a new persistent class
• 5de53766 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 80 commits

• 5de53766...a085ed8b - 73 commits from branch atlas:main
• 17870a71 - Drop unnecessary includes of MCTruth/TrackBarcodeInfo.h
• 348644b6 - PrimaryParticleInformation - add GetUniqueID method and drop unused SuggestBarcode method
• 48c83b31 - Update TrackBarcodeInfo constructor to take uniqueID as well as barcode +...
• 991fad1d - Add parentUniqueID method to TruthIncidents
• 15b20782 - Add ISFParticle::id() method
• 1a27ecb0 - Add status to transient TrackRecord class and add, but not use a new persistent class
• 6ba80ec2 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 1230 commits

• 6ba80ec2...25fa6bb5 - 1226 commits from branch atlas:main
• 87a67148 - Add parentUniqueID method to TruthIncidents
• ffa07c5f - Add ISFParticle::id() method
• ac9e0a0e - Add status to transient TrackRecord class and add, but not use a new persistent class
• 404130f7 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

Following the creation of the 24.0 branch from main, you should now decide whether this MR should target 24.0 or main, according to these guidelines agreed in the Software Weekly meeting: https://indico.cern.ch/event/1382755/attachments/2802320/4889268/BranchingGuidelines24.pdf If you decide that this MR should target 24.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in main, please indicate this as a reply to this message. Remember that all MRs going into 24.0 will also be swept into main.

resolved all threads

added 3012 commits

• 404130f7...23fb305f - 3004 commits from branch atlas:main
• 24bf8e12 - Remove obsolete BitCalculator and TruthDressRoom classes
• 76f0e02a - Drop obsolete ITruthIncident::parentBCID() method
• 9555307e - Remove obsolete m_bcid member variable and getter/setter methods from ISFParticle
• 1f04fc97 - Drop obsolete ISFParticle::m_bcid member variable
• 62d619a3 - Add parentUniqueID method to TruthIncidents
• ebe9f6dd - Add ISFParticle::id() method
• 002d8f5a - Add status to transient TrackRecord class and add, but not use a new persistent class
• ea4af376 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 125 commits

• ea4af376...523ef7f6 - 121 commits from branch atlas:main
• d4d5a4e7 - Add parentUniqueID method to TruthIncidents
• d88b5649 - Add ISFParticle::id() method
• 6ba29a71 - Add status to transient TrackRecord class and add, but not use a new persistent class
• 14524111 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 560 commits

• 14524111...2e945ef4 - 556 commits from branch atlas:main
• 2415caa0 - Add parentUniqueID method to TruthIncidents
• 8be4f35d - Add ISFParticle::id() method
• 00d212db - Add status to transient TrackRecord class and add, but not use a new persistent class
• 0cf6abb9 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 1 commit

• 1b9af736 - More changes

Compare with previous version

added 208 commits

• 1b9af736...a98f73a4 - 201 commits from branch atlas:main
• 8243e926 - Clean-up of TrackRecord header ahead of further updates
• 0ab1a1da - Migrate clients to updated method names for getting and setting barcodes
• 57b2bd94 - Fixup
• f7fc3acf - Add parentUniqueID method to TruthIncidents
• 57cdc015 - Add ISFParticle::id() method
• 586a7d45 - Add status to transient TrackRecord class and add, but not use a new persistent class
• 1ca7026a - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 1 commit

• 685aa710 - Add UniqueID to VTrackInformation classes and TrackHelper in MCTruth package

Compare with previous version

added 1 commit

• ae2b630b - Set status and id in transient TrackRecord class and add, but not use a new persistent class

Compare with previous version

added 4 commits

• c07a4d0a - minor patch to TrackHelper.cxx
• 36ca0597 - Add parentUniqueID method to TruthIncidents
• 09d652d1 - Add ISFParticle::id() method
• 4b96d6cb - Add status and id to transient TrackRecord class and add, but not use a new persistent class

Compare with previous version

added 15 commits

• 4b96d6cb...8a84c695 - 10 commits from branch atlas:main
• 1fe2be0c - Clean-up of TrackRecord header ahead of further updates
• 3ff24315 - Migrate clients to updated method names for getting and setting barcodes
• cc133824 - Fixup
• 03a53525 - minor patch to TrackHelper.cxx
• 4e1ab8f8 - Add status and id to transient TrackRecord class and add, but not use a new persistent class

Compare with previous version

Jenkins please retry a build

This merge request affects 17 packages:

• Event/PyDumper
• MuonSpectrometer/MuonTruthAlgs
• MuonSpectrometer/MuonValidation/MuonPRDTest
• MuonSpectrometer/MuonValidation/MuonRecValidation/MuonTrackPerformance
• PhysicsAnalysis/D3PDMaker/D3PDMakerTest
• PhysicsAnalysis/D3PDMaker/MuonD3PDMaker
• Simulation/G4Sim/MCTruth
• Simulation/G4Sim/MCTruthBase
• Simulation/G4Sim/TrackRecord
• Simulation/G4SimCnv/G4SimTPCnv
• Simulation/G4Utilities/G4UserActions
• Simulation/G4Utilities/TrackWriteFastSim
• Simulation/ISF/ISF_Geant4/ISF_Geant4CommonTools
• Simulation/TruthJiveXML
• Tracking/TrkTools/TrkTruthToTrack
• Trigger/TrigT1/TrigT1NSWSimTools
• graphics/VP1/VP1Systems/VP1TrackSystems

Affected files list will not be printed in this case

Adding @pscholer ,@rosati ,@stavrop ,@jchapman ,@apsallid ,@rbianchi ,@kluit ,@jojungge ,@gemmeren as watchers

added Analysis EDM EventDisplay MuonSpectrometer Simulation Tracking Trigger main labels

WARNING: big files (>100K) are found in the changeset

196K in file Event/PyDumper/python/Dumpers.py

CI Result FAILURE (hash 4e1ab8f8)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7056] (remote access info)

marked this merge request as ready

added 39 commits

• 4e1ab8f8...c235001b - 36 commits from branch atlas:main
• 004eda9a - Fixup
• 41d96ca1 - minor patch to TrackHelper.cxx
• 87685b13 - Add status and id to transient TrackRecord class and add, but not use a new persistent class

Compare with previous version

This merge request affects 9 packages:

• PhysicsAnalysis/D3PDMaker/D3PDMakerTest
• PhysicsAnalysis/D3PDMaker/MuonD3PDMaker
• Simulation/G4Sim/MCTruth
• Simulation/G4Sim/MCTruthBase
• Simulation/G4Sim/TrackRecord
• Simulation/G4SimCnv/G4SimTPCnv
• Simulation/G4Utilities/G4UserActions
• Simulation/G4Utilities/TrackWriteFastSim
• Simulation/ISF/ISF_Geant4/ISF_Geant4CommonTools

Affected files list will not be printed in this case

Adding @gemmeren ,@jchapman as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 87685b13)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7090] (remote access info)

MR looks fine from L1 perspective, CI shows no problems - approving.

Cheers, L1 shifter

removed review-pending-level-1 label

added review-approved label

mentioned in commit 8169500b

merged