Skip to content
Snippets Groups Projects

adding keepStrongVertices option, see ATLHI-483

Merged Aaron Angerami requested to merge angerami/athena:hijing-fix-rel23-ATLHI-483/main into main
All threads resolved!

Fixes ATLHI-483 by adding keepStrongVertices option. Solves issue where decay vertex strongly decaying resonances were not set properly. Keeping these vertices is now the default, but the old behavior can be restored by changing this flag to False in the job options.

Merge request reports

Pipeline #6098373 passed

Pipeline passed for ee02f0b2 on angerami:hijing-fix-rel23-ATLHI-483/main

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Aug 24, 2023 6:54pm UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Changes look fine, I only have one small comment.

    Setting review-user-action-required.

    Cheers, Steffen (L1)

  • Aaron Angerami added 1 commit

    added 1 commit

    • ee02f0b2 - removing leftover print statement

    Compare with previous version

  • This merge request affects 1 package:

    • Generators/Hijing_i

    This merge request affects 2 files:

    • Generators/Hijing_i/Hijing_i/Hijing.h
    • Generators/Hijing_i/src/Hijing.cxx
  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash ee02f0b2)

    Athena AthGeneration
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76863]

  • Vakhtang Tsulaia mentioned in commit c5e25b78

    mentioned in commit c5e25b78

  • John Derek Chapman picked the changes into the branch cherry-pick-c5e25b78 with commit 12ad2ef5

    picked the changes into the branch cherry-pick-c5e25b78 with commit 12ad2ef5

  • Vakhtang Tsulaia mentioned in commit 12ad2ef5

    mentioned in commit 12ad2ef5

  • John Derek Chapman mentioned in merge request !65676 (merged)

    mentioned in merge request !65676 (merged)

  • mentioned in commit 8ae88cba

  • Please register or sign in to reply
    Loading