Fix endcap ring indices for new geometry in FPGATackingSim

With the data of newst geometry we encouter a problem that some of the hits can not be assigned to new logical layers in the endcap. Thanks to @brosser we have now the right set of indices. However we are still missing new map files on CVMFS (@kazheng is working on this) so at the moment a hacky solution is provided in this MR. In the future we'll be switching between mapping using proper flags. FI @jahreda @brosser

changed title from Draft: Generaise config to use the right geo version to Draft: Generalise config to use the right geo version

changed the description

added 1 commit

• a308e465 - Fix layers

Compare with previous version

Hi @tbold,

There's another instance of the disk index stored in the FPGATrackSimMapMakerAlg.h header that also needs to be updated, unfortunately.

(By the way, the map maker algorithm can generate plane map files from a wrapper; unfortunately it has to know the "logical layer" assignment for a given region-- which physical layers correspond to the 8 (or 9 or 13) logical layers/planes. It then figures out the (etamin, etamax) and (phimin, phimax) ranges for each physical layer that go into the plane map file. Unfortunately, there's not currently a way to derive this assignment, it's also just hardcoded in the header. Trying to figure this out is why I was looking at the diskIndex remapping to begin with).

changed the description

marked this merge request as ready

changed title from Draft: Generalise config to use the right geo version to Fix endcap ring indices for new geometry in FPGATackingSim

changed the description

This merge request affects 2 packages:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimConfTools
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimMaps

Affected files list will not be printed in this case

added EFTracking Trigger main review-pending-level-1 labels

CI Result SUCCESS (hash a308e465)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77243]

Marking as review-user-action-required while threads are open.

Cheers, Steffen (L1)

added review-user-action-required label and removed review-pending-level-1 label

removed review-user-action-required label

added review-pending-level-1 label

MR looks fine from L1 perspective - Approving.

Cheers, Steffen (L1)

resolved all threads

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 3753af00

Has this MR caused this https://its.cern.ch/jira/browse/ATR-28212 ?

mentioned in commit c3268bf6

mentioned in merge request !65688 (merged)

mentioned in commit a4fb1866

added sweep:ignore label