jFEX cleaning coded
This MR is meant to clean the jFEX code since some declarations were wrong, as well as some unclear getters
Merge request reports
Activity
added Run3L1Calo label
This merge request affects 1 package:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
This merge request affects 4 files:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/jTower.h
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXSysSim.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXmetAlgo.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jTower.cxx
added 23.0 Trigger review-pending-level-1 labels
CI Result SUCCESS (hash 2559950b)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77231]- Resolved by Sergi Rodriguez Bosca
@serodrig I have one small comment. Can you have a look at it?
Apart from that this looks fine to me.
Setting review-user-action-required
Cheers, Steffen (L1)
added review-user-action-required label
removed review-pending-level-1 label
This merge request affects 1 package:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
This merge request affects 4 files:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/jTower.h
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXSysSim.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXmetAlgo.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jTower.cxx
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 1b5d4c9c)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77259]removed review-pending-level-1 label
added review-approved label
added review-approved-tier0 label
added review-approved-point1 label
mentioned in commit b9d93902
mentioned in merge request !65545 (merged)