Skip to content
Snippets Groups Projects

jFEX cleaning coded

Merged Sergi Rodriguez Bosca requested to merge serodrig/athena:TowerCoords into 23.0
All threads resolved!

This MR is meant to clean the jFEX code since some declarations were wrong, as well as some unclear getters

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @serodrig I have one small comment. Can you have a look at it?

    Apart from that this looks fine to me.

    Setting review-user-action-required

    Cheers, Steffen (L1)

  • Sergi Rodriguez Bosca resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

    This merge request affects 4 files:

    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/jTower.h
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXSysSim.cxx
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXmetAlgo.cxx
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jTower.cxx

    Adding @thompson ,@serodrig as watchers

  • :white_check_mark: CI Result SUCCESS (hash 1b5d4c9c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77259]

  • Jiri Masik mentioned in commit b9d93902

    mentioned in commit b9d93902

  • merged

  • Adam Edward Barton mentioned in merge request !65545 (merged)

    mentioned in merge request !65545 (merged)

  • Please register or sign in to reply
    Loading