ATR-28029 - ATR-22061 - Update

ATR-28029: Adding to Menu_Physics_HI_run3_v1.py:

• L1_gJ20p0ETA25
• L1_gJ400p0ETA25
• L1_gLJ80p0ETA25
• L1_gTE200
• L1_gXEJWOJ100

Adding also corresponding HLT chains:

• HLT_noalg_L1gJ20p0ETA25
• HLT_noalg_L1gJ400p0ETA25
• HLT_noalg_L1gLJ80p0ETA25
• HLT_noalg_L1gTE200
• HLT_noalg_L1gXEJWOJ100
• HLT_j110_a10t_lcw_jes_L1gLJ80p0ETA25
• HLT_j110_a10sd_cssk_pf_jes_ftf_preselj80_L1gLJ80p0ETA25
• HLT_noalg_L1gLJ80p0ETA25

ATR-22061

• L1_eEM9_EMPTY (Menu_Physics_HI_run3_v1.py)

\cc @astruebi @lidiaz

assigned to @mrimoldi

added 1 commit

• f45d10ee - Adding HLT gj and HLT_j110_a

Compare with previous version

changed the description

added 1 commit

• d24d5618 - Adding HLT_noalg_L1gLJ80p0ETA25

Compare with previous version

Hi @mrimoldi, I was asked to check this urgently. While I don't see any problem with moving the triggers between categories, there is nothing matching the current description. Please submit updates soon and if !65466 (merged) gets merged meanwhile rebase to 23.0 to work around possible conflicts in the ref files cheers Jiri

added 1 commit

• f6da7b24 - last fix

Compare with previous version

added 1 commit

• 9eeb032d - fix HLY

Compare with previous version

changed the description

Hi @mrinoldi - there are merge conflicts now after I merged !65466 (merged). Please can you undraft and then do refresh from upstream and rebase to upstream/23.0 to resolve the conflict and make the CI run? cheers Jiri

marked this merge request as ready

added 11 commits

• 9eeb032d...e1671dc8 - 10 commits from branch atlas:23.0
• 88437921 - Merge branch '23.0' into 'ATR-28029-ATR-22061'

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 4 files:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/P1_run3_v1.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/PhysicsP1_HI_run3_v1.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/PhysicsP1_pp_lowMu_run3_v1.py
• Trigger/TriggerCommon/TriggerMenuMT/python/L1/Menu/Menu_Physics_HI_run3_v1.py

Adding @sutt ,@ademaria ,@ggonella ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

added 23.0 Trigger TriggerMenu review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 88437921)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77268]

References need to be updated

--- a/Trigger/TrigValidation/TriggerTest/share/ref_mc_v1DevHI_build.ref
+++ b/Trigger/TrigValidation/TriggerTest/share/ref_mc_v1DevHI_build.ref
@@ -2471,2 +2471,12 @@
   eventCount: 20
+HLT_noalg_L1gJ20p0ETA25:
+  eventCount: 0
+HLT_noalg_L1gJ400p0ETA25:
+  eventCount: 0
+HLT_noalg_L1gLJ80p0ETA25:
+  eventCount: 0
+HLT_noalg_L1gTE200:
+  eventCount: 0
+HLT_noalg_L1gXEJWOJ100:
+  eventCount: 10
 HLT_noalg_L1jJ40:

added review-user-action-required label and removed review-pending-level-1 label

Hi @mrimoldi, I noticed only now you are placing the gFex streamers in the Main stream. However, in the HI menu we actually don't use the Main stream at all. Can you please move the gJ, gLJ and gXE streamers to the HardProbes stream, and the gTE streamer to the MinBias stream? Tagging also @asmaga in case she has a different proposal for target streams.

added 11 commits

• 88437921...aaf427ef - 10 commits from branch atlas:23.0
• eaada185 - Merge branch '23.0' into 'ATR-28029-ATR-22061'

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 4 files:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/P1_run3_v1.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/PhysicsP1_HI_run3_v1.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/PhysicsP1_pp_lowMu_run3_v1.py
• Trigger/TriggerCommon/TriggerMenuMT/python/L1/Menu/Menu_Physics_HI_run3_v1.py

Adding @sutt ,@ademaria ,@ggonella ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• 0242ec38 - Fix test - change seedThrA-B-C 3 GeV - fix stream

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@ggonella ,@vmartin ,@okumura ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

added changes-trigger-counts label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash eaada185)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77284]

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 0242ec38)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77287]

resolved all threads

mentioned in merge request !65497 (merged)

Hello @jmasik - exceptionally may we merge this today still with a failing reference check.

Once merged I will un-draft !65497 (merged) which could then be set to auto-merge on successful CI

added review-approved-point1 label

merged

mentioned in commit 96ad8264

mentioned in commit 1cd26073

mentioned in commit 99b5910d

mentioned in merge request !65510 (merged)

To mention for the record, that this MR also modified seed thresholds for large-R gFex reco (gLJ seeds), which modifies HLT large-R jet container content and trigger counts in pp reprocessings (due to increased L1 trigger count).