Skip to content
Snippets Groups Projects

Fix for the masked module hits(missing hits) being counted as holes.

Merged Bhupesh Dixit requested to merge bdixit/athena:nSCT_Holes_Count_Fix into main
All threads resolved!

Previously the modules that were masked and hence had a hit missing were being counted as holes. This commit allows to use of a different preExec command for masking i.e. --preExec 'ConfigFlags.ITk.doStripModuleVeto = True; ConfigFlags.ITk.JsonPath="path/to/the/json/file"' to be exact. Earlier when any algorithm (other than the ITkStripClusterization) called on 'ITkStripModuleVetoCfg' it found that JsonPath to be empty and that by default meant that no modules were masked, in contrast now they can find the JsonPath to be non-empty.

Edited by Bhupesh Dixit

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bhupesh Dixit changed title from Bug fix for the masked module hits(missing hits) being counted as holes. to Fix for the masked module hits(missing hits) being counted as holes.

    changed title from Bug fix for the masked module hits(missing hits) being counted as holes. to Fix for the masked module hits(missing hits) being counted as holes.

  • Bhupesh Dixit changed the description

    changed the description

  • Bhupesh Dixit added 1 commit

    added 1 commit

    • ea01b476 - Name of flag changed from JsonPath to JsonPathStripModuleVeto.

    Compare with previous version

  • Bhupesh Dixit resolved all threads

    resolved all threads

  • This merge request affects 2 packages:

    • InnerDetector/InDetConditions/SCT_ConditionsTools
    • InnerDetector/InDetConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@sroe as watchers

  • :white_check_mark: CI Result SUCCESS (hash ea01b476)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77286]

  • Changes look fine from L1 perspective and threads were resolved - Approving.

    Cheers, Steffen (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier mentioned in commit 2a32ed6e

    mentioned in commit 2a32ed6e

  • Please register or sign in to reply
    Loading