Fix for the masked module hits(missing hits) being counted as holes.
Previously the modules that were masked and hence had a hit missing were being counted as holes. This commit allows to use of a different preExec command for masking i.e. --preExec 'ConfigFlags.ITk.doStripModuleVeto = True; ConfigFlags.ITk.JsonPath="path/to/the/json/file"' to be exact. Earlier when any algorithm (other than the ITkStripClusterization) called on 'ITkStripModuleVetoCfg' it found that JsonPath to be empty and that by default meant that no modules were masked, in contrast now they can find the JsonPath to be non-empty.
Merge request reports
Activity
requested review from @sroe
requested review from @nstyles
added InnerDetector main review-pending-level-1 labels
CI Result SUCCESS (hash 05c3cd9a)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77251]added ITk label
- Resolved by Thomas Strebler
Can you explain in more details why setting an empty
JsonPath
argument fixes the issue?
- Resolved by Bhupesh Dixit
added 1 commit
- ea01b476 - Name of flag changed from JsonPath to JsonPathStripModuleVeto.
CI Result SUCCESS (hash ea01b476)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77286]added review-approved label and removed review-pending-level-1 label
mentioned in commit 2a32ed6e