Skip to content
Snippets Groups Projects

Plot RoI map for the first leg only in multi-leg triggers [ATR-26626]

All threads resolved!

If we have a multipe-leg trigger, the monitoring RoI map should look at the first leg only, so that a HLT_eX_tauX chain would only produce an entry in the electron RoI map.

This fixes ATR-26626.

While the original problem (that the jet RoI map is non-empty) is rare, the fix should reduce the RoI multiplicity in a way that is noticeable even in few events, as suggested by @tamartin .
I have checked this on the AOD from 23.0/Athena/x86_64-centos7-gcc11-opt/2023-08-30T2101/TrigAnalysisTest/test_trigAna_RDOtoRun3DQ_v1Dev_build/ (20 events) and the RoI map event count reduced compared with the out-of-box test:
HLT_MuonsRoIs 640 -> 577
HLT_ElectronsRoIs: 659 -> 648

While this change is in no way urgent, it would be nice to have it in as soon as possible.

Tagging also @sshaw , @shanisch , @tnobe .

Merge request reports

Pipeline #6133384 passed

Pipeline passed for 32fe8cb2 on ebergeas:pick-roi-from-first-leg-only

Approval is optional

Merged by Jiri MasikJiri Masik 1 year ago (Sep 1, 2023 2:47pm UTC)

Merge details

  • Changes merged into 23.0 with 63ab32c5 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jiri Masik resolved all threads

    resolved all threads

  • merged

  • Jiri Masik mentioned in commit 63ab32c5

    mentioned in commit 63ab32c5

  • Adam Edward Barton mentioned in merge request !65545 (merged)

    mentioned in merge request !65545 (merged)

  • Please register or sign in to reply
    Loading